[#45347] - [5.4] Optimize smart search module
- Fixed in Code Base
- 22 Aug 2025
- Medium
- Build: 5.3-dev
- # 45347
- Diff
- Denitz:patch-19
User tests: Successful: Unsuccessful:
Summary of Changes
Smart Search module creates new Query and triggers Joomla\Component\Finder\Administrator\Indexer::processString() method which loads available taxonomy branch titles via separate SQL query per each module (duplicate query).
We should not process empty string, when the module is loaded without any input. Plus, Taxonomy::getBranchTitles() load should use static cache and produce only single query to prevent duplicate when we have multiple mod_finder instances (i.e. typical case for Yootheme templates where one module is rendered in header and second in mobile dialog).
Testing Instructions
Create two Smart Search modules, apply patch,
Actual result BEFORE applying this Pull Request
Load page with Smart Search modules, see duplicate queries like:
SELECT `title`
FROM `jos_finder_taxonomy`
WHERE `parent_id` = 1 AND `state` = 1 AND `access` IN (1,5)Expected result AFTER applying this Pull Request
No useless queries, the mod_finder render time is also faster now.
Link to documentations
- No documentation changes for docs.joomla.org needed
- No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_finder |
| Labels |
Added:
PR-5.3-dev
|
||
| Title |
|
||||||
I have tested this item ✅ successfully on 7826570
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45347.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45347.
| Labels |
Added:
RTC
|
||
While I agree with these changes, I also don't think it is a bugfix and thus should go into 5.4
| Title |
|
||||||
OK, changed to 5.4
| Labels |
Added:
PR-5.4-dev
Removed: PR-5.3-dev |
||
As it was a clean rebase without conflicts, the tests and RTC are still valid, and I've just reviewed the changes. They are all ok.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-08-22 11:01:09 |
| Closed_By | ⇒ | richard67 |
I have tested this item ✅ successfully on 7826570
I see the number of queries decrease by 2 on both the pages with two modules and the results page with a side module. No problems observed.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45347.