[#45251] - [6.0] Removing broken getForm from installer UpdateModel
- Fixed in Code Base
- 10 Apr 2025
- Medium
- Build: 6.0-dev
- # 45251
- Diff
- Hackwar:6.0-installer-update
User tests: Successful: Unsuccessful:
Summary of Changes
During codereview I noticed that the getForm() method of the UpdateModel class is not used at all. It seems to be a remnant of the past and is also broken. There is no form XML for this method. Thus I'm removing it entirely.
Testing Instructions
Codereview? Test updating an extension?
Actual result BEFORE applying this Pull Request
Everything works.
Expected result AFTER applying this Pull Request
Everything works.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_installer |
| Labels |
Added:
PR-6.0-dev
|
||
I have tested this item ✅ successfully on 6a690e8
I have installed 6 different extensions (2 components (small and complex), 2 modules, 2 plugins and updated 2 of them) and uninstall them all. Checked that they all worked. Everything worked as expected.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45251.
I have tested this item ✅ successfully on 6a690e8
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45251.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45251.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-04-10 14:09:05 |
| Closed_By | ⇒ | wilsonge |
Thanks!
You can remove
use Joomla\CMS\Form\Form;