[#45250] - [6.0] Removing defs of JPATH_COMPONENT* from installation app
- Ready to Commit
- Medium
- Build: 6.0-dev
- # 45250
- Diff
- Hackwar:6.0-install-constants
User tests: Successful: Unsuccessful:
Summary of Changes
The constants JPATH_COMPONENT, JPATH_COMPONENT_SITE and JPATH_COMPONENT_ADMINISTRATOR are deprecated, but Joomla itself is still using it in some places. Among them is the installation of the CMS, which defines these constants unnecessarily. This PR removes those definitions. Please be aware that this PR depends on #45249 to be merged.
Testing Instructions
Run through an installation of Joomla both in the browser and the CLI.
Actual result BEFORE applying this Pull Request
Everything works.
Expected result AFTER applying this Pull Request
Everything works, but we don't have the constants anymore.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Installation |
I have tested this item ✅ successfully on d9da696
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45250.
| Labels |
Added:
PR-6.0-dev
|
||
I have tested this item ✅ successfully on 4dceaaa
I have successfully tested this :)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45250.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45250.
| Labels |
Added:
RTC
|
||
I have tested this item ✅ successfully on 751788c
Works same as 45249
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45250.
I have tested this item ✅ successfully on cad0f11
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45250.
| Status | Ready to Commit | ⇒ | Pending |
Back to pending as the PR has received a change. As I've just tested with success, it needs only one more test.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45250.
@brianteeman @exlemor @softforge Could one of you three test this PR again? It has received changes so I have removed RTC, but I have tested it with success right now, so it needs only one more test. Thanks in advance.
I have tested this item ✅ successfully on cad0f11
retested both web and cli installation
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45250.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45250.
@brianteeman Thanks for testing again.
@exlemor @softforge No further test needed, PR is RTC again.
As I tested an installation successfully with #45249 this looks good to me