[#45232] - [5.4] Author None and Created by me filter
- Fixed in Code Base
- 13 Apr 2025
- Medium
- Build: 5.4-dev
- # 45232
- Diff
- brianteeman:nonsense
User tests: Successful: Unsuccessful:
Summary of Changes
replacement pr for #45192 #45191
In the admin articles view when filtering by author you have the option to filter the authors "created by me"
This PR adds that option to the articles featured view in the admin AND the articles modal view in the frontend
There is a check in the Author column to display the author name if the id is not 0 else to display the author as None
I believe this check to be incorrect. When a user is deleted from the users table the created_by in the content table is untouched so the condition in the query is never passed.
This PR changes the condition to check for the author_name in the featured articles and this way we can satisfy the condition and are able to display the author as None
New in this PR
The string displayed in the filter dropdown for "Created by me" has been added to the site language and changed to be wrapped in - like other filter strings
The display of the string "None" to indicate no author in the list view has been wrapped in [ ] to differentiate it from a user who could theoretically be called none
Testing Instructions
Create two users
Create featured articles with each user
Delete one of the users
Check the author column in the admin content list and content featured list
Check the author filter in the admin content list and content featured list AND the article modals
Expected result AFTER applying this Pull Request
The articles view in the admin does have the option "created by me"
The features articles view in the admin does have the option "created by me"
The article modal when accessed from the CMS Content - Article button when editing an article in the front end does have the option "created by me"
The article modal when accessed from the CMS Content - Article button when editing an article in the admin does have the option "created by me"
the filters are displayed as shown as in the screenshot above
The deleted author is shown as in the screenshot above
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content Language & Strings Front End |
@brianteeman Part of the "Expected result …" should be changed:
The features articles view in the admin does
nothave the option "created by me"
The article modal when accessed from the CMS Content - Article button when editing an article in the front end doesnothave the option "created by me"
I have tested this item ✅ successfully on e548167
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45232.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
Language Change
PR-5.4-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45232.
@brianteeman Part of the "Expected result …" should be changed:
The features articles view in the admin does
nothave the option "created by me"
The article modal when accessed from the CMS Content - Article button when editing an article in the front end doesnothave the option "created by me"
@fgsw thanks for spotting that - I have updated the instructions
@brianteeman It seems you have fixed only the 2nd one but not the 1st one he had mentioned, because that still is
The features articles view in the admin does
nothave the option "created by me"
Updated
@brianteeman Do I observe right that for successful filtering for deleted users (- None -) it needs PR #45186 in addition? It seems that PR has a mistake as it breaks the "Created by me" filter, see my test result there.
And should we use the same, dashes for the filtering options and squared brackets for the display in the list, also at other places in the administrator, e.g. in PRs #45223 for the username in the User Notes list and in PR #45201 for the field group name in fields lists?
Just asking for your advise. Nothing to be changed in this PR here, it is fine.
@richard67 yes
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-04-13 12:21:55 |
| Closed_By | ⇒ | richard67 |
Thanks all (author and testers).
thanks
I have tested this item ✅ successfully on e548167
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45232.