[#4517] - Remove Mootools usage in com_menu
- Closed
- 22 Oct 2014
- Medium
- Build: staging
- # 4517
- Diff
- Fedik:mootools-from-menus-edit
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Remove Mootools usage in com_menu
additionally to #4475
Test
apply path and make sure that menu (and menu items) editing in the com_menu still works 
Votes
jissues-bot
- | Labels |
Added:
?
|
||
jespersoelundhansen
- 
| Status | Pending | ⇒ | Ready to Commit |
durgesh4
- 
Mootools still loaded here
@infograf768 yes right, because it required by the modal script that used for select the article (example),
and JHtml::_('behavior.formvalidation'); still call mootools, this part hope will be fixed by related pull #4475
maybe I made a bad description,
this pull remove mootools usage in the menu editing template, but some fields that on this page still can load mootools
@infograf768 @Fedik Also the toolbar buttons have hard coded call to mootools #4475 takes care of that but needs some fixes on unit tests (the old behavior.core was injecting mt, the new is not…). As it is right now I realize that is quite hard to review and test it, so I will break it in more parts so it will be easier to reviewed and tested
Shall we then merge this one as it solves the validation ?
| Milestone | |||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-10-22 07:15:48 |
@infograf768 Hathor seems to have overrides for all these views https://github.com/joomla/joomla-cms/blob/staging/administrator/templates/hathor/html/com_menus/item/edit.php#L48-L76
Shall we change that as well?
mbabker
- | Milestone | |||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone | |||
Setting to RTC - thanks for testing
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4517.