[#45149] - [5.3] Fix incorrect error message when failing to rename a file due to an existing destination.
- Pending
- Medium
- Build: 5.2-dev
- # 45149
- Diff
- krishnaGandhi11:ErrorFix
User tests: Successful: Unsuccessful:
Pull Request for Issue #45087,
Summary of Changes:
Testing Instructions
Navigate to the file manager in Joomla where renaming files is possible. (Refer how to reproduce at #45087)
Actual result BEFORE applying this Pull Request
The error messages may appear incorrectly or out of order, causing confusion:
1."Error renaming item." (Correct but unclear without context)
2. "Move file is not possible as destination already exists." (Sometimes redundant or misleading)
Expected result AFTER applying this Pull Request
1st : Error renaming item: Please choose a file name with a-z, A-Z, 0-9, ., - and _.(Avoid Special Characters also name should
not start or end with a period )
2nd : Action not Possible as a file with this name already Exists
- Ensuring that they do not contradict each other and
clearly indicate why the operation failed.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings NPM Change |
| Labels |
Added:
Language Change
NPM Resource Changed
PR-5.2-dev
|
||
This pull request has been automatically rebased to 5.3-dev.
| Title |
|
||||||
If im not wrong your PR only changes the grammar of the error messages being shown ?
The second error regarding the file destination already existing shouldn't be shown at all, a file with the same name doesn't exist.
It is likely that it is falling back to a default when there is an error sanitising due to which that error is being shown.
The first error will be shown whenever there is trouble renaming the file not just when there are invalid characters. So you can't just change what that error message says to only apply for this case.
IMO #45145 is a better PR for this issue, Do share your thoughts on this.