User tests: Successful: 0 Unsuccessful: 0
Pull Request for Issue #44993.
Updates the http package to the latest version which includes a PHP 8.4 fix. more infromation about the release can be found in https://github.com/joomla-framework/http/releases/tag/3.1.0.
Run the unit tests or follow the testing instructions in the issue.
Warning:
_Deprecated: Joomla\Http\Http::_construct(): Implicitly marking parameter $transport as nullable is deprecated, the explicit nullable type must be used instead
No more warning.
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Status | New | ⇒ | Pending |
Category | ⇒ | External Library Composer Change |
@laoneo - I turned on deprecated log ini the Global Configuration - and I am not finding that message anywhere in the installation prior to applying the PR via download the Prebuilt Package - why did I misunderstand? (I can't run unit tests)
@exlemor If you can't run unit tests but can access unit test logs in Drone (which should be the case), you can check if the message is in the PHP 8.4 unit test log from the last commit in the 5.3-dev branch here: https://ci.joomla.org/joomla/joomla-cms/83345/1/13
And if it is not in the PHP 8.4 unit test log for this PR here: https://ci.joomla.org/joomla/joomla-cms/83403/1/13
I have tested this item ✅ successfully on bc1b6ec
The log of the PHP 8.4 unit tests with Drone for the latest commit in the 5.3-dev branch shows the deprecation warning 2 times: https://ci.joomla.org/joomla/joomla-cms/83345/1/13
PHP Deprecated: Joomla\Http\Http::__construct(): Implicitly marking parameter $transport as nullable is deprecated, the explicit nullable type must be used instead in /drone/src/libraries/vendor/joomla/http/src/Http.php on line 51
............................................................
Deprecated: Joomla\Http\Http::__construct(): Implicitly marking parameter $transport as nullable is deprecated, the explicit nullable type must be used instead in /drone/src/libraries/vendor/joomla/http/src/Http.php on line 51
The log of the PHP 8.4 unit tests with Drone for this PR does not show that warning: https://ci.joomla.org/joomla/joomla-cms/83403/1/13
I have tested this item ✅ successfully on bc1b6ec
I have tested this successfully - (thanks to @richard67 for the clarity).
Status | Pending | ⇒ | Ready to Commit |
Labels |
Added:
Composer Dependency Changed
PR-5.3-dev
|
RTC
PLEASE can someone merge this - sick of seeing the deprecation in my logs
PLEASE can someone merge this - sick of seeing the deprecation in my logs
till yesterday the branch was locked, after conflicts is resolved this will be merged
Labels |
Added:
RTC
|
I wasnt aware of that - thanks for the info
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-03-19 16:19:35 |
Closed_By | ⇒ | rdeutz |
thanks!!!
@laoneo - I turned on deprecated log ini the Global Configuration - and I am not finding that message anywhere in the installation prior to applying the PR via download the Prebuilt Package - why did I misunderstand? (I can't run unit tests)