RTC Composer Dependency Changed PR-5.3-dev Pending

User tests: Successful: 0 Unsuccessful: 0

avatar laoneo
laoneo
16 Mar 2025

Pull Request for Issue #44993.

Summary of Changes

Updates the http package to the latest version which includes a PHP 8.4 fix. more infromation about the release can be found in https://github.com/joomla-framework/http/releases/tag/3.1.0.

Testing Instructions

Run the unit tests or follow the testing instructions in the issue.

Actual result BEFORE applying this Pull Request

Warning:
_Deprecated: Joomla\Http\Http::_construct(): Implicitly marking parameter $transport as nullable is deprecated, the explicit nullable type must be used instead

Expected result AFTER applying this Pull Request

No more warning.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar laoneo laoneo - open - 16 Mar 2025
avatar laoneo laoneo - change - 16 Mar 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Mar 2025
Category External Library Composer Change
avatar exlemor
exlemor - comment - 16 Mar 2025

@laoneo - I turned on deprecated log ini the Global Configuration - and I am not finding that message anywhere in the installation prior to applying the PR via download the Prebuilt Package - why did I misunderstand? (I can't run unit tests)

avatar richard67
richard67 - comment - 16 Mar 2025

@laoneo - I turned on deprecated log ini the Global Configuration - and I am not finding that message anywhere in the installation prior to applying the PR via download the Prebuilt Package - why did I misunderstand? (I can't run unit tests)

@exlemor If you can't run unit tests but can access unit test logs in Drone (which should be the case), you can check if the message is in the PHP 8.4 unit test log from the last commit in the 5.3-dev branch here: https://ci.joomla.org/joomla/joomla-cms/83345/1/13

And if it is not in the PHP 8.4 unit test log for this PR here: https://ci.joomla.org/joomla/joomla-cms/83403/1/13

avatar richard67 richard67 - test_item - 16 Mar 2025 - Tested successfully
avatar richard67
richard67 - comment - 16 Mar 2025

I have tested this item ✅ successfully on bc1b6ec

The log of the PHP 8.4 unit tests with Drone for the latest commit in the 5.3-dev branch shows the deprecation warning 2 times: https://ci.joomla.org/joomla/joomla-cms/83345/1/13


PHP Deprecated:  Joomla\Http\Http::__construct(): Implicitly marking parameter $transport as nullable is deprecated, the explicit nullable type must be used instead in /drone/src/libraries/vendor/joomla/http/src/Http.php on line 51

............................................................

Deprecated: Joomla\Http\Http::__construct(): Implicitly marking parameter $transport as nullable is deprecated, the explicit nullable type must be used instead in /drone/src/libraries/vendor/joomla/http/src/Http.php on line 51

The log of the PHP 8.4 unit tests with Drone for this PR does not show that warning: https://ci.joomla.org/joomla/joomla-cms/83403/1/13


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45148.
avatar exlemor exlemor - test_item - 16 Mar 2025 - Tested successfully
avatar exlemor
exlemor - comment - 16 Mar 2025

I have tested this item ✅ successfully on bc1b6ec

I have tested this successfully - (thanks to @richard67 for the clarity).


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45148.

avatar richard67 richard67 - change - 16 Mar 2025
Status Pending Ready to Commit
Labels Added: Composer Dependency Changed PR-5.3-dev
avatar richard67
richard67 - comment - 16 Mar 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45148.

avatar brianteeman
brianteeman - comment - 19 Mar 2025

PLEASE can someone merge this - sick of seeing the deprecation in my logs

avatar HLeithner
HLeithner - comment - 19 Mar 2025

PLEASE can someone merge this - sick of seeing the deprecation in my logs

till yesterday the branch was locked, after conflicts is resolved this will be merged

avatar laoneo laoneo - change - 19 Mar 2025
Labels Added: RTC
avatar brianteeman
brianteeman - comment - 19 Mar 2025

I wasnt aware of that - thanks for the info

avatar rdeutz rdeutz - change - 19 Mar 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-03-19 16:19:35
Closed_By rdeutz
avatar rdeutz rdeutz - close - 19 Mar 2025
avatar rdeutz rdeutz - merge - 19 Mar 2025
avatar brianteeman
brianteeman - comment - 19 Mar 2025

thanks!!!

Add a Comment

Login with GitHub to post a comment