User tests: Successful: Unsuccessful:
Pull Request for Issue #45087 .
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
| Category | ⇒ | Administration com_media Language & Strings |
| Title |
|
||||||
I have tested this item 🔴 unsuccessfully on 44e5e47
i will say that the filename handling tested successfully, however the language en-GB did not seem to pull the right language translation. it showed the language key token, "COM_MEDIA_ERROR_INVALID_FILENAME" instead of, "Invalid file name."
The patch Is successful in getting error when renaming a file/folder with a special symbol, but it displays an incorrect error message
This pull request has been automatically rebased to 5.3-dev.
| Title |
|
||||||
This pull request has been automatically rebased to 5.4-dev.
| Title |
|
||||||
| Labels |
Added:
Language Change
bug
PR-5.4-dev
|
||
I have tested this item 🔴 unsuccessfully on 840b384
Missing language string:
@richard67 can you update this PR with the missing language string. The op has clearly abandoned this so it will never get fixed and will stay stuck here for another year
@richard67 can you update this PR with the missing language string. The op has clearly abandoned this so it will never get fixed and will stay stuck here for another year
@brianteeman Done.
I have tested this PR and it does exactly what it says but thats not enough. It only addresses the invalid character $ but the exact same problem exists for lots of other invalid characters such as # @ * and many more. It should be checking for all invalid characters not just the $
This was already mentioned in the original bug report #45087 (comment)
I have tested this item 🔴 unsuccessfully on d48bfe9
@richard67 as the original author has clearly "gone away" and this PR doesn't address the problem correctly I recommend closing this PR and re-opening the original issue
@STUDYHUB02 Thank you for your work so far. Would you like to continue working on this PR, or if not, could you please close it? If we do not receive a response, we will close this PR after two weeks.
This change should be made in the local adapter and not in the model. It is very likely that cloud providers do accept the $ sign in file names.
The changes in this PR does not make any sense. I would suggest to close it.
I have tested this item 🔴 unsuccessfully on 44e5e47
Tested with mixed results;
https://snipboard.io/bofT4D.jpg
After patch, file is not renamed (success), but the error shown is not the expected string/message (fail).
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45141.