Feeling Lucky
PR-5.3-dev
[#45103] - [5.3] Catch undefined cors options when saving global options
- Ready to Commit
- Medium
- Build: 5.3-dev
- # 45103
- Diff
- Digital-Peak:cli/config
User tests: Successful: Unsuccessful:
Summary of Changes
When saving an option on cli, then are undefined property warnings thrown on error reporting maximum.
Testing Instructions
Execut cli/joomla.php config:set debug=1 on the console within the joomla root folder.
Actual result BEFORE applying this Pull Request
The following four warnings are displayed:
Warning: Undefined array key "cors" in /var/www/html/Projects/cms5/administrator/components/com_config/src/Model/ApplicationModel.php on line 748
Warning: Undefined array key "cors_allow_origin" in /var/www/html/Projects/cms5/administrator/components/com_config/src/Model/ApplicationModel.php on line 749
Warning: Undefined array key "cors_allow_headers" in /var/www/html/Projects/cms5/administrator/components/com_config/src/Model/ApplicationModel.php on line 750
Warning: Undefined array key "cors_allow_methods" in /var/www/html/Projects/cms5/administrator/components/com_config/src/Model/ApplicationModel.php on line 751
Expected result AFTER applying this Pull Request
No warnings.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_config |
| Labels |
Added:
PR-5.3-dev
|
||
alikon
- comment
- 11 Mar 2025
I have tested this item ✅ successfully on edf6bc8
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45103.
| Status | Pending | ⇒ | Ready to Commit |
alikon
- comment
- 11 Mar 2025
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45103.
I have tested this item ✅ successfully on edf6bc8
Before applying this PR and if the four
cors*-entries are deleted fromconfiguration.phpfile, the four deprecation warnings are shown. After applying this PR no deprecation warnings are shown anymore and enabling/disablingDebug Systemcontinues to work with Joomla Command Line Interface.This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45103.