Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#45091] - [5.3][cypress] avoid deprecated in api tags

RTC PR-5.3-dev Pending

User tests: Successful: 1 brianteeman Unsuccessful: 0

avatar alikon
alikon
7 Mar 2025

Pull Request for Issue # .

Summary of Changes

set default

Testing Instructions

npx cypress run --spec '.\tests\System\integration\api\com_tags\Tags.cy.js

Actual result BEFORE applying this Pull Request

PHP Deprecated: explode(): Passing null to parameter #2 ($string) of type string is deprecated in ..\530\administrator\components\com_tags\src\Model\TagsModel.php on line 299

Expected result AFTER applying this Pull Request

no more deprecated

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar alikon alikon - open - 7 Mar 2025
avatar alikon alikon - change - 7 Mar 2025
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Mar 2025
Category ⇒ com_tags Administration
avatar alikon alikon - change - 7 Mar 2025
The description was changed
avatar alikon alikon - edited - 7 Mar 2025
avatar alikon alikon - change - 7 Mar 2025
Title
…
avoid deprecated
[5.3][cypress] avoid deprecated in api tags
avatar alikon alikon - edited - 7 Mar 2025
avatar muhme muhme - test_item - 10 Mar 2025 - Tested successfully
avatar muhme
muhme - comment - 10 Mar 2025

I have tested this item ✅ successfully on 49f2add

Tested with hacked JBT. Before applying the PR there a two deprecated warnings. After applying the PR the test spec still passed and there are no deprecated warnings.

Additional Note:

  • This depreaction was added in PHP 8.1
  • It doesn't need to enable Log Almost Everything in Joomla backend
  • It doesn't need to enable Log Deprecated API in Joomla backend
  • Windows Laragon shows the deprecation in php_errors.log file
  • Due logging with ¿SAPI (Server Application Programming Interface)? in macOS and Linux images in Docker the warning is not in the Apache error log or Docker log, as the other warnings
  • To see the deprecation, you have to configure php.ini or Apache in e.g. /etc/apache2/sites-enabled/000-default.conf file:
	php_flag log_errors on
        php_flag display_errors on
        php_value error_log /var/log/apache2/php_errors.log

And check by hand after the test:

docker exec jbt-53 cat /var/log/apache2/php_errors.log
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45091.
avatar laoneo laoneo - test_item - 10 Mar 2025 - Tested successfully
avatar laoneo
laoneo - comment - 10 Mar 2025

I have tested this item ✅ successfully on 49f2add

I'v manually removed the state in the code to see the error. After applying the patch, the error is gone.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45091.

avatar laoneo laoneo - change - 10 Mar 2025
Status Pending ⇒ Ready to Commit
avatar laoneo
laoneo - comment - 10 Mar 2025

rtc

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45091.

avatar laoneo laoneo - change - 10 Mar 2025
Labels Added: RTC
avatar QuyTon QuyTon - change - 10 Mar 2025
Labels Added: PR-5.3-dev
avatar brianteeman brianteeman - test_item - 10 Mar 2025 - Tested successfully
avatar brianteeman
brianteeman - comment - 10 Mar 2025

I have tested this item ✅ successfully on 9ad4735

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45091.

Add a Comment

Login with GitHub to post a comment