[#45083] - [5.2] Fix activation status
- Closed
- 10 Mar 2025
- Medium
- Build: 5.2-dev
- # 45083
- Diff
- Amitesh007z:fix-activation-status
User tests: Successful: Unsuccessful:
Pull Request for Issue #45063 .
Summary of Changes
Fixed the activation status issue where the "Activated" flag remained inactive even after the user verified their email.
Ensured that once a user completes email verification, the administrator can see the updated activation status correctly unless and untill the New User Account Activation is not Adminstator , like if its Adminstator , once Admin approves by clicking the link in his mail ,it turns activated.
Modified language/en-GB/ and administrator/language/en-GB/ files to reflect updated changes.
Testing Instructions
1.Register aa a new user and check if email verification updates the activation status.
2.Test cases where New User Account Activation is set to different values (e.g., Self, Admin) to ensure correct behavior i.e if self ,then on clicking link updates activated in admin panel and for Admin , changes to activated in admin panel upon approval of admin by clicking link in mail received upon mail verification of user.
3.Verify that the updated language strings are correctly reflected in the UI.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Beforre verification :
Once after verification also by admin(as it is set as By Admin instead of self):
Once after language change:
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_users Language & Strings |
@Amitesh007z Can you please:
- append the issue number (45063) in "Pull Request for Issue #."
- start the title "[5.2] " (example #44733) as titles are used in the changelog.
Thank you.
| Title |
|
||||||
| Title |
|
||||||
| Title |
|
||||||
| Labels |
Added:
Language Change
PR-5.2-dev
|
||
| Category | Administration com_users Language & Strings | ⇒ | Administration com_banners com_users Language & Strings Front End com_contact Unit Tests Repository |
| Labels |
Added:
Unit/System Tests
|
||
@Amitesh007z Thanks for changing the title. Can you please delete the issue number from the title as it makes no sense to have it in the changelog.
| Title |
|
||||||
| Category | Administration com_users Language & Strings com_banners Front End com_contact Unit Tests Repository | ⇒ | Administration com_banners com_users Language & Strings Repository Front End com_contact External Library Composer Change Unit Tests |
@Amitesh007z Thanks for changing the title. Can you please delete the issue number from the title as it makes no sense to have it in the changelog.
yeah done , sorry for inconvenience caused ,
thanks
This PR shows a lot of unrelated changes, e.g. fine administrator/language/en-GB/install.xml and other XML files, composer.json and so on. Maybe the base branch was chosen wrong?
| Labels |
Added:
Composer Dependency Changed
|
||
This PR shows a lot of unrelated changes, e.g. fine administrator/language/en-GB/install.xml and other XML files, composer.json and so on. Maybe the base branch was chosen wrong?
Sorry for the inconvenience caused till now @richard67 , i have changed only few set of lines which are related to the issue i.e state change of activated and enabled basically , also as an additional task was to rename and change few terms with better replacements to avoid confusions and in order to provide clarity ,so i have changed some lines in language/en-GB mainly , will look into all errors, in CI tests and once everything is sorted will be happy to hear your review ,Sorry for calling upon re-review without checking all cases in CI tests passed,
Thanks
I think the problem is that your fix-activation-status branch for this PR was created based on a different branch than 5.2-dev (maybe 5.3-dev?) and then this PR was created for 5.2-dev, so the branches do not match and the PR shows all the unrelated changes because it shows the differences of the 5.2-dev and 5.3-dev branches, too. You could try to rebase this PR to 5.3-dev, or you could make a new PR.
I think the problem is that your fix-activation-status branch for this PR was created based on a different branch than 5.2-dev (maybe 5.3-dev?) and then this PR was created for 5.2-dev, so the branches do not match and the PR shows all the unrelated changes because it shows the differences of the 5.2-dev and 5.3-dev branches, too. You could try to rebase this PR to 5.3-dev, or you could make a new PR.
I have reviewed the branch sir , and it appears to be in sync with 5.2-dev. However, I will cross-check once more to ensure there are no discrepancies. If I find any inconsistencies, I will take the necessary steps to resolve them and update accordingly. Thank you for your guidance sir !
| Category | Administration com_users Language & Strings com_banners Front End com_contact Unit Tests Repository External Library Composer Change | ⇒ | Administration com_banners com_categories com_cpanel com_fields com_finder com_joomlaupdate com_menus com_modules com_plugins com_redirect com_templates com_users com_workflow Language & Strings |
| Labels |
Removed:
Unit/System Tests
Composer Dependency Changed
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-03-10 17:34:27 |
| Closed_By | ⇒ | Amitesh007z |
I noticed that my current PR includes several unintended changes. To keep the contribution clean and focused, I will close the existing PR and create a new one with only the necessary modifications. will get it done in couple of hours with intended chnages Thanks
For the reasons I stated in the original issue report I am personally not in favour of changing the string to "verified" as in some of the user registration methods there is no verification step.
Before even looking at changing anything I think you need to create a grid showing the values for enabled and activated at each step of the registration process for each scenario. Only then can we even determine if something is not working correctly. These are some of the oldest settings in Joomla and I would be very careful changing anything without having a full understanding of the intended results