RTC PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar reem-atalah
reem-atalah
5 Mar 2025

Pull Request for Issue #45069.

Summary of Changes

  • Sorted the task types alphabetically when creating a new task in the Scheduler component.
  • Applied sorting after task options are collected from plugins using usort().
  • Ensured consistent ordering of task types in the UI.

Testing Instructions

Select System → Manage panel → Scheduled Tasks → click New
Verify that task types are displayed in alphabetical order.

Actual result BEFORE applying this Pull Request

Task types appeared in an unordered manner based on how plugins loaded them.
image

Expected result AFTER applying this Pull Request

Task types are always sorted alphabetically, making selection easier.
image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar reem-atalah reem-atalah - open - 5 Mar 2025
avatar reem-atalah reem-atalah - change - 5 Mar 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Mar 2025
Category Administration com_content
avatar reem-atalah reem-atalah - change - 5 Mar 2025
Labels Added: PR-5.3-dev
avatar joomla-cms-bot joomla-cms-bot - change - 5 Mar 2025
Category Administration com_content Administration
avatar fgsw fgsw - test_item - 6 Mar 2025 - Tested successfully
avatar fgsw
fgsw - comment - 6 Mar 2025

I have tested this item ✅ successfully on adb49f7

Test by using the custom update server of the prebuilt packages.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45080.

avatar reem-atalah
reem-atalah - comment - 6 Mar 2025

Hello @fgsw thanks for testing, Can I know what's next so my code can be merged?

avatar fgsw
fgsw - comment - 6 Mar 2025

Can I know what's next so my code can be merged?

@reem-atalah The PR is now RTC. We will just need to wait for maintainer to review and merge it.

Originally posted by @joomdonation in #45065 (comment)

@reem-atalah Please don't double post.

avatar richard67
richard67 - comment - 6 Mar 2025

@reem-atalah The PR is now RTC. We will just need to wait for maintainer to review and merge it.

@fgsw This here not. It still needs one more test.

@reem-atalah When a PR has 2 tests by 2 users who are not the author of the PR, it gets RTC (ready to commit) status and label. Then maintainers will review and merge if ok.

avatar brianteeman
brianteeman - comment - 6 Mar 2025

@reem-atalah When a PR has 2 tests by 2 users who are not the author of the PR, it gets RTC (ready to commit) status and label. Then maintainers will review and merge if ok.

and just because something is tested the maintainers may decide that its a change or feature that they dont want to accept

avatar reem-atalah
reem-atalah - comment - 6 Mar 2025

@fgsw @richard67 @brianteeman thanks for all your clarifications.

avatar ChristineWk ChristineWk - test_item - 6 Mar 2025 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 6 Mar 2025

I have tested this item ✅ successfully on adb49f7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45080.

avatar richard67 richard67 - change - 6 Mar 2025
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 6 Mar 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45080.

avatar rdeutz rdeutz - change - 8 Mar 2025
Labels Added: RTC
avatar rdeutz rdeutz - change - 8 Mar 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-03-08 17:53:51
Closed_By rdeutz
avatar rdeutz rdeutz - close - 8 Mar 2025
avatar rdeutz rdeutz - merge - 8 Mar 2025
avatar rdeutz
rdeutz - comment - 8 Mar 2025

Thanks

Add a Comment

Login with GitHub to post a comment