Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#45061] - [5.3][cypress] Add tests for shortcut plugin

Unit/System Tests PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar heelc29
heelc29
2 Mar 2025

Summary of Changes

test function of shortcut plugin

Testing Instructions

  • npx cypress run --spec '.\tests\System\integration\plugins\system\shortcut\ShortcutPlugin.cy.js'

Actual result BEFORE applying this Pull Request

not tested

Expected result AFTER applying this Pull Request

tested

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed
avatar heelc29 heelc29 - open - 2 Mar 2025
avatar heelc29 heelc29 - change - 2 Mar 2025
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Mar 2025
Category ⇒ JavaScript Unit Tests
avatar heelc29 heelc29 - change - 2 Mar 2025
Labels Added: Unit/System Tests PR-5.2-dev
avatar alikon
alikon - comment - 2 Mar 2025

something left from #45059

avatar heelc29
heelc29 - comment - 2 Mar 2025

something left from #45059

Yes, otherwise ci fails
https://ci.joomla.org/joomla/joomla-cms/82835

avatar alikon
alikon - comment - 2 Mar 2025

ah ok , then better to test/merge #45059 first

avatar alikon
alikon - comment - 2 Mar 2025

now #45059 has been merged

avatar alikon
alikon - comment - 2 Mar 2025

i'll mark this tested successfully tested without the now unneeded 2 files from #45059

avatar alikon alikon - test_item - 2 Mar 2025 - Tested successfully
avatar alikon
alikon - comment - 2 Mar 2025

I have tested this item ✅ successfully on 21d890e

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45061.

avatar laoneo
laoneo - comment - 3 Mar 2025

Can you rebase this pr to 5.3? Better to focus now on 5.3. Thanks...

avatar brianteeman brianteeman - test_item - 3 Mar 2025 - Tested unsuccessfully
avatar brianteeman
brianteeman - comment - 3 Mar 2025

I have tested this item 🔴 unsuccessfully on 21d890e

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45061.

avatar joomla-cms-bot joomla-cms-bot - change - 3 Mar 2025
Category JavaScript Unit Tests ⇒ Unit Tests Repository JavaScript
avatar heelc29 heelc29 - change - 3 Mar 2025
Title
…
[5.2][cypress] Add tests for shortcut plugin
[5.3][cypress] Add tests for shortcut plugin
avatar heelc29 heelc29 - edited - 3 Mar 2025
avatar brianteeman
brianteeman - comment - 3 Mar 2025

please do not include unrelated files.

avatar heelc29
heelc29 - comment - 3 Mar 2025

please do not include unrelated files.

Missing upmerge from 5.2 to 5.3

avatar brianteeman
brianteeman - comment - 3 Mar 2025

then you should put a note in the PR testing instructions about that. They should not be in this PR!!

avatar heelc29
heelc29 - comment - 3 Mar 2025

then you should put a note in the PR testing instructions about that. They should not be in this PR!!

Draft now

avatar laoneo laoneo - change - 5 Mar 2025
Labels Added: PR-5.3-dev
avatar laoneo
laoneo - comment - 5 Mar 2025

5.3 should have now the changes from #45059

avatar heelc29
heelc29 - comment - 5 Mar 2025

@laoneo Do I miss something ... I don't see an Upmerge form 5.2-dev to 5.3-dev
5.3-dev still missing 2 commits - including #45059
image

avatar laoneo
laoneo - comment - 5 Mar 2025

Ah sorry, then I missed it. Thought I saw it in my local repo.

avatar laoneo laoneo - change - 7 Mar 2025
Labels Removed: PR-5.2-dev
avatar joomla-cms-bot joomla-cms-bot - change - 7 Mar 2025
Category JavaScript Unit Tests Repository ⇒ JavaScript Unit Tests
avatar laoneo laoneo - change - 7 Mar 2025
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2025-03-07 14:18:10
Closed_By ⇒ laoneo
avatar laoneo laoneo - close - 7 Mar 2025
avatar laoneo laoneo - merge - 7 Mar 2025
avatar laoneo
laoneo - comment - 7 Mar 2025

Thanks!

Add a Comment

Login with GitHub to post a comment