PR-6.0-dev Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
28 Feb 2025

Summary of Changes

The doctrine/inflector package is currently stuck on version 1.4.4, which right now is 4 years old. The current version 2.0.10 is mostly compatible - except for the Doctrine\Common\Inflector\Inflector class, which was deprecated and removed in 2.0. Unfortunately that class is the basis for the joomla/string packages inflector class. Since that base class is deprecated, this code removes all usages of the Joomla inflector package from our core code and instead uses the Doctrine package directly. The next step would be to update the package to the latest version, but that would break our joomla/string package, at least in our current situation. Fixing the string package to work with the newer code is left for someone else to work on...

The improvement here is, that it removes the usage of deprecated code and makes phpstan happy.

Testing Instructions

  • Visit a category/tags/workflow list view in the backend.
  • Via the REST API,
    • submit a form to com_contact
    • create an override for a language string in com_language
    • save and delete a media item in com_media
    • edit a plugin in com_plugins
    • save a template style in com_templates

In each case it should all behave like before.

Or alternatively do a codereview.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar Hackwar Hackwar - open - 28 Feb 2025
avatar Hackwar Hackwar - change - 28 Feb 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Feb 2025
Category Administration com_categories com_tags com_workflow Libraries Front End Plugins
avatar Hackwar Hackwar - change - 28 Feb 2025
Labels Added: PR-6.0-dev
avatar Hackwar
Hackwar - comment - 1 Mar 2025

Be my guest. Right now I'm just going to unify the code to use the same stuff everywhere.

avatar Hackwar Hackwar - change - 8 Aug 2025
The description was changed
avatar Hackwar Hackwar - edited - 8 Aug 2025
avatar brianteeman
brianteeman - comment - 10 Aug 2025

Not really sure what/how to test here as the test instructions are VERY incomplete

but after reading the code in administrator\components\com_tags\tmpl\tags\default.php I did some tests to ensure that the value of $section is the same before and after the PR

avatar softforge softforge - change - 11 Aug 2025
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-08-11 21:03:56
Closed_By softforge
avatar softforge softforge - close - 11 Aug 2025
avatar softforge softforge - merge - 11 Aug 2025
avatar softforge
softforge - comment - 11 Aug 2025

Thank you for the work on this, the code reviews and help going through this.

Add a Comment

Login with GitHub to post a comment