[#45040] - [6.0] Replace all joomla/string inflector code
- Pending
- Medium
- Build: 6.0-dev
- # 45040
- Diff
- Hackwar:6.0-doctrine-inflector
User tests: Successful: Unsuccessful:
Summary of Changes
The doctrine/inflector package is currently stuck on version 1.4.4, which right now is 4 years old. The current version 2.0.10 is mostly compatible - except for the Doctrine\Common\Inflector\Inflector class, which was deprecated and removed in 2.0. Unfortunately that class is the basis for the joomla/string packages inflector class. Since that base class is deprecated, this code removes all usages of the Joomla inflector package from our core code and instead uses the Doctrine package directly. The next step would be to update the package to the latest version, but that would break our joomla/string package, at least in our current situation. Fixing the string package to work with the newer code is left for someone else to work on...
The improvement here is, that it removes the usage of deprecated code and makes phpstan happy.
Testing Instructions
Codereview?
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_categories com_tags com_workflow Libraries Front End Plugins |
| Labels |
Added:
PR-6.0-dev
|
||
Be my guest. Right now I'm just going to unify the code to use the same stuff everywhere.