[#45039] - [6.1] Remove useless empty () check #
- Fixed in Code Base
- 29 Nov 2025
- Medium
- Build: 5.3-dev
- # 45039
- Diff
- joomdonation:remove_empty_form_check
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
The loadForm method from FormBehaviorTrait (which is used by our models) always return a Form object on success and throw Exception on failure, so all empty($form) check in our model classes are useless, it never returns false, thus should be moved from models code.
Testing Instructions
This will require careful code review from our testers and maintainer.
Actual result BEFORE applying this Pull Request
Works
Expected result AFTER applying this Pull Request
Works, slight faster because the useless code is removed, thus not being executed.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_associations com_banners com_categories com_config com_contact com_content com_fields com_finder com_installer com_languages com_media com_menus com_messages com_modules com_newsfeeds com_plugins com_redirect |
| Title |
|
||||||
| Labels |
Added:
PR-5.3-dev
|
||
This pull request has been automatically rebased to 5.4-dev.
This pull request has been automatically rebased to 6.1-dev.
| Title |
|
||||||
@joomdonation would you be so kind and fix the conflict, I plan this for 6.1
| Labels |
Added:
Feature
PR-6.1-dev
|
||
| Labels |
Removed:
PR-5.3-dev
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-11-29 12:10:25 |
| Closed_By | ⇒ | tecpromotion |
Thanks @joomdonation for this PR.
LadySolveig
- | Title |
|
||||||
Thanks for reviewing and merging the PR. I had another look at our code again and see that the way we handle error when calling method is in-consistent:
- Some tries to handle the case it return false (which does not really happen)
- And most of the times, the caller code does not care/handle error at all (mean the Exception not handled and leave it to global error handler to handle)
So what should we do the caller side? Remove the code which handles false return ?
@joomdonation Can you please provide testing instructions - how can we test this? - 58 files in code review may not be enough.
Love to include it in PBF which is today :)