[#44991] - [6.0] Drop Bootstrap::framework
- Pending
- Medium
- Build: 6.0-dev
- # 44991
- Diff
- dgrammatiko:6.0-dev/remove-bs-fw
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
- B/C break
- Drop Bootstrap::framework Since J4 any bootstrap (js) component should be specifically loaded, the framework fn was kept for compatibility
Testing Instructions
- code review
- Add
HTMLHelper::_('bootstrap.framework');somewhere in theindex.phpof the atum template - Check that all the BS components are registered
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org: PR
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository Libraries NPM Change |
| Labels |
Added:
NPM Resource Changed
PR-6.0-dev
|
||
| Labels |
Added:
b/c break
|
||
| Category | Repository Libraries NPM Change | ⇒ | Libraries |
| Labels |
Removed:
NPM Resource Changed
|
||
| Category | Libraries | ⇒ | Libraries Front End Plugins |
Do we have to add the deprecated tag to the methods in the compat plugin as well?
Do we have to add the deprecated tag to the methods in the compat plugin as well?
To me it feels redundant, as it will never show up in the IDE
I agree that it wont show up in the IDE, but it will prevent any discussions in the future about removal and deprecation if you move the tag from the old code also over to the new code.
Thank you!
@dgrammatiko I like this change and the addition to the compatibility plugin, to then remove it after.
Can you do as @HLeithner suggested and we can get testing done and merge it
the implementation in the b/c plugin is not optimal.
please add a new Class for this function and also an option to disable "all html helper functions" (do we have more?) and make it as option please.
please add a new Class
what namespace? is namespace Joomla\Plugin\Behaviour\Compat\HTML\Bootstrap ok?
and also an option
simple toggle should be ok here?
@softforge the first batch of requests is already done, I'll do the lest 2 later on (or tomorrow)
yes namespace is ok, we already have yes/no fields in the config. something like that
| Category | Libraries Front End Plugins | ⇒ | Administration Language & Strings Libraries Front End Plugins |
- toggler added
- moved to own class
| Labels |
Added:
Language Change
|
||
| Labels |
Added:
Removal
|
||
I have tested this item ✅ successfully on 30d3736
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44991.
Istead fo removing, I would move it to the compat plugin.