Feature RTC PR-6.0-dev Pending

User tests: Successful: Unsuccessful:

avatar heelc29
heelc29
24 Feb 2025

Summary of Changes

Use WebAssets in Joomla installation template

Testing Instructions

check if /media/system/js/fields/validate.min.js is loaded when install joomla

Actual result BEFORE applying this Pull Request

HTMLHelper is used

* @deprecated 4.0 will be removed in 6.0
* Use the webasset manager instead
* Example: Factory::getApplication()->getDocument()->getWebAssetManager()->useScript('form.validate');

Expected result AFTER applying this Pull Request

WebAssetManager is used in main template file

->useScript('form.validate')

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed
avatar heelc29 heelc29 - open - 24 Feb 2025
avatar heelc29 heelc29 - change - 24 Feb 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Feb 2025
Category Installation
avatar heelc29 heelc29 - change - 25 Feb 2025
Labels Added: PR-5.3-dev
avatar heelc29 heelc29 - change - 1 Mar 2025
Labels Added: Feature
avatar HLeithner
HLeithner - comment - 4 Mar 2025

This pull request has been automatically rebased to 6.0-dev.

avatar HLeithner HLeithner - change - 4 Mar 2025
Title
[5.3] Use WebAsset for installation
[6.0] Use WebAsset for installation
avatar HLeithner HLeithner - edited - 4 Mar 2025
avatar joomla-cms-bot joomla-cms-bot - change - 4 Mar 2025
Category Installation Administration SQL com_admin Postgresql com_associations com_banners com_categories com_checkin com_config com_contact com_content com_contenthistory com_cpanel com_fields com_finder com_installer com_joomlaupdate
avatar heelc29 heelc29 - change - 15 Mar 2025
Labels Added: PR-6.0-dev
Removed: PR-5.3-dev
avatar joomla-cms-bot joomla-cms-bot - change - 15 Mar 2025
Category Administration SQL com_admin Postgresql com_associations com_banners com_categories com_checkin com_config com_contact com_content com_contenthistory com_cpanel com_fields com_finder com_installer com_joomlaupdate Installation
avatar ceford
ceford - comment - 2 Jun 2025

Could you clarify the testing instructions? Is this one where you have to download the code with the patch applied and then do a new Joomla install? I have never done one of those so will probably leave it to others to test.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45000.

avatar heelc29
heelc29 - comment - 2 Jun 2025

Could you clarify the testing instructions? Is this one where you have to download the code with the patch applied and then do a new Joomla install? I have never done one of those so will probably leave it to others to test.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45000.

To use the patch tester its required to have an installed Joomla instance. To test this PR you need the installation application -> patch tester not working
Its better to use the prebuild package or checkout the git branch (needs composer/npm ...)

avatar brianteeman
brianteeman - comment - 11 Aug 2025

The old and new line is not needed at all as we already load the validate script in the main template file

->useScript('form.validate')

avatar chmst
chmst - comment - 11 Aug 2025

As @brianteeman says, the ines can be removed completely.

avatar heelc29 heelc29 - change - 12 Aug 2025
Labels Added: Updates Requested
avatar heelc29
heelc29 - comment - 12 Aug 2025

The old and new line is not needed at all as we already load the validate script in the main template file

As @brianteeman says, the ines can be removed completely.

Done. Didn't notice that it was already loaded.

avatar heelc29 heelc29 - change - 12 Aug 2025
The description was changed
avatar heelc29 heelc29 - edited - 12 Aug 2025
avatar heelc29 heelc29 - change - 12 Aug 2025
The description was changed
avatar heelc29 heelc29 - edited - 12 Aug 2025
avatar brianteeman brianteeman - test_item - 12 Aug 2025 - Tested successfully
avatar brianteeman
brianteeman - comment - 12 Aug 2025

I have tested this item ✅ successfully on df10f14


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45000.

avatar exlemor exlemor - test_item - 16 Aug 2025 - Tested successfully
avatar exlemor
exlemor - comment - 16 Aug 2025

I have tested this item ✅ successfully on df10f14

I have tested this successfully with Phil and Gary in attendance ;) Thanks @heelc29!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45000.

avatar richard67 richard67 - change - 16 Aug 2025
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 16 Aug 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45000.

avatar richard67 richard67 - change - 16 Aug 2025
Labels Added: RTC
avatar Bodge-IT Bodge-IT - change - 16 Aug 2025
Labels Removed: Updates Requested
avatar Bodge-IT Bodge-IT - change - 16 Aug 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-08-16 19:26:39
Closed_By Bodge-IT
avatar Bodge-IT Bodge-IT - close - 16 Aug 2025
avatar Bodge-IT Bodge-IT - merge - 16 Aug 2025
avatar Bodge-IT
Bodge-IT - comment - 16 Aug 2025

Thanks @heelc29 for your work on this and thanks @brianteeman and @exlemor for testing

Add a Comment

Login with GitHub to post a comment