RTC PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
23 Feb 2025

Pull Request for Issue # .

Summary of Changes

This PR improves code quality of our code base by running PHPCS Fixer for combine_consecutive_unsets rule.

Testing Instructions

Code review

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works, with cleaner code

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomdonation joomdonation - open - 23 Feb 2025
avatar joomdonation joomdonation - change - 23 Feb 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Feb 2025
Category Administration com_associations com_config com_joomlaupdate com_menus com_modules com_templates Libraries Front End Plugins
be9ed6d 23 Feb 2025 avatar joomdonation CS
avatar joomdonation joomdonation - change - 23 Feb 2025
Labels Added: PR-5.3-dev
avatar chmst chmst - test_item - 23 Feb 2025 - Tested successfully
avatar chmst
chmst - comment - 23 Feb 2025

I have tested this item ✅ successfully on be9ed6d

code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44983.

avatar QuyTon
QuyTon - comment - 23 Feb 2025

Please fix extra blank lines.

avatar joomdonation
joomdonation - comment - 24 Feb 2025

Done. Thanks @QuyTon

avatar QuyTon QuyTon - test_item - 24 Feb 2025 - Tested successfully
avatar QuyTon
QuyTon - comment - 24 Feb 2025

I have tested this item ✅ successfully on fe5ccf2

Thank you!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44983.

avatar QuyTon QuyTon - alter_testresult - 24 Feb 2025 - chmst: Tested successfully
avatar QuyTon QuyTon - change - 24 Feb 2025
Status Pending Ready to Commit
avatar QuyTon
QuyTon - comment - 24 Feb 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44983.

avatar joomdonation joomdonation - change - 24 Feb 2025
Labels Added: RTC
avatar HLeithner HLeithner - close - 26 Feb 2025
avatar HLeithner HLeithner - merge - 26 Feb 2025
avatar HLeithner HLeithner - change - 26 Feb 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-02-26 18:05:56
Closed_By HLeithner

Add a Comment

Login with GitHub to post a comment