RTC PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
23 Feb 2025

Pull Request for Issue # .

Summary of Changes

This PR improves code quality of our code base by running PHPCS Fixer for combine_consecutive_issets rule.

Testing Instructions

Code review

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works, with cleaner code

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomdonation joomdonation - open - 23 Feb 2025
avatar joomdonation joomdonation - change - 23 Feb 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Feb 2025
Category Administration com_associations com_checkin com_config com_content com_contenthistory com_fields com_menus Modules Front End com_finder com_tags com_users Libraries Plugins
avatar joomdonation joomdonation - change - 23 Feb 2025
Labels Added: PR-5.3-dev
avatar QuyTon QuyTon - test_item - 23 Feb 2025 - Tested successfully
avatar QuyTon
QuyTon - comment - 23 Feb 2025

I have tested this item ✅ successfully on be06c9d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44982.

avatar viocassel viocassel - test_item - 24 Feb 2025 - Tested successfully
avatar viocassel
viocassel - comment - 24 Feb 2025

I have tested this item ✅ successfully on be06c9d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44982.

avatar QuyTon QuyTon - change - 24 Feb 2025
Status Pending Ready to Commit
avatar QuyTon
QuyTon - comment - 24 Feb 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44982.

avatar HLeithner HLeithner - change - 26 Feb 2025
Labels Added: RTC
avatar HLeithner HLeithner - close - 26 Feb 2025
avatar HLeithner HLeithner - merge - 26 Feb 2025
avatar HLeithner HLeithner - change - 26 Feb 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-02-26 18:07:42
Closed_By HLeithner
avatar HLeithner
HLeithner - comment - 26 Feb 2025

thx

avatar joomdonation
joomdonation - comment - 27 Feb 2025

Thanks Harald for merging. And many thanks people who spent time to review these kind of PRs, especially @QuyTon and @viocassel.

Add a Comment

Login with GitHub to post a comment