RTC bug PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
22 Feb 2025

Pull Request for Issue #44542.

Summary of Changes

Currently, the GroupModel model uses wrong asset name for permission check, so permission checking for field groups does not work at all. The right name of assist is something like com_content.fieldgroup.20 but we are checking using com_content.article.fieldgroup.20 . This PR fixes that wrong behavior

Testing Instructions

  • Use Joomla 5.3
  • Create a new field group for Content. Look at Permissions tab, set Edit State permission of that field for Administrator user group to Denied.
  • Save it.
  • Logout, then login using an Administrator account.
  • Check on the checkbox next to the field group and try to use Publish button in the toolbar to publish that
  • Try to click on field group to edit

Actual result BEFORE applying this Pull Request

You can publish field group, although Administrator does not have permission to do that.
You can change value for Published field of the field group

Expected result AFTER applying this Pull Request

  • There is an error message when try to publish that field group
  • You are not allowed to change Published field for the field group

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomdonation joomdonation - open - 22 Feb 2025
avatar joomdonation joomdonation - change - 22 Feb 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Feb 2025
Category Administration com_fields
avatar crommie crommie - test_item - 22 Feb 2025 - Tested successfully
avatar crommie
crommie - comment - 22 Feb 2025

I have tested this item ✅ successfully on 3a9733f

Followed instructions, works as described


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44956.

avatar komalm komalm - test_item - 22 Feb 2025 - Tested successfully
avatar komalm
komalm - comment - 22 Feb 2025

I have tested this item ✅ successfully on 3a9733f

Expected Results After Applying the Patch
The Published field should be disabled or inaccessible when editing the field group


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44956.

avatar joomdonation joomdonation - change - 22 Feb 2025
Status Pending Ready to Commit
avatar joomdonation
joomdonation - comment - 22 Feb 2025

RTC. Thanks for testing.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44956.

avatar rdeutz rdeutz - change - 27 Feb 2025
Labels Added: RTC bug PR-5.3-dev
avatar rdeutz rdeutz - change - 27 Feb 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-02-27 17:26:59
Closed_By rdeutz
avatar rdeutz rdeutz - close - 27 Feb 2025
avatar rdeutz rdeutz - merge - 27 Feb 2025

Add a Comment

Login with GitHub to post a comment