Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#44952] - [5.3] Fix MailsHelper::loadTranslationFiles bug

RTC PBF PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
22 Feb 2025

Pull Request for Issue #44686.

Summary of Changes

This PR fixes wrong code implemented in PR #44730. We need to load frontend language files, so the code should use JPATH_SITE instead of JPATH_BASE as implemented in the PR.

I also replace the deprecated Factory::getLanguage() method by Factory::getApplication()->getLanguage()

Testing Instructions

  • Use Joomla 5.3 nightly build
  • Go to mailtemplates and open Contacts: Contact Form Mail
  • See that the language strings are not translated
  • Do not save but cancel (!)
  • Apply the patch
  • Notice that the string is now translated

Actual result BEFORE applying this Pull Request

Strings are not translated

Expected result AFTER applying this Pull Request

Strings are translated

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomdonation joomdonation - open - 22 Feb 2025
avatar joomdonation joomdonation - change - 22 Feb 2025
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Feb 2025
Category ⇒ Administration
avatar komalm komalm - test_item - 22 Feb 2025 - Tested successfully
avatar komalm
komalm - comment - 22 Feb 2025

I have tested this item ✅ successfully on c5d0150

Expected After Patch: The language strings should be properly translated, reflecting the correct content.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44952.

avatar Pritams43 Pritams43 - test_item - 22 Feb 2025 - Tested successfully
avatar Pritams43
Pritams43 - comment - 22 Feb 2025

I have tested this item ✅ successfully on c5d0150

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44952.

avatar alikon alikon - change - 22 Feb 2025
Status Pending ⇒ Ready to Commit
avatar alikon
alikon - comment - 22 Feb 2025

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44952.

avatar HLeithner HLeithner - change - 27 Feb 2025
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2025-02-27 11:28:29
Closed_By ⇒ HLeithner
Labels Added: RTC PBF PR-5.3-dev
avatar HLeithner HLeithner - close - 27 Feb 2025
avatar HLeithner HLeithner - merge - 27 Feb 2025
avatar HLeithner
HLeithner - comment - 27 Feb 2025

thx

Add a Comment

Login with GitHub to post a comment