RTC bug PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar SniperSister
SniperSister
21 Feb 2025

Pull Request for Issue #44732

Summary of Changes

The security fix introduced in Joomla 5.2.3 causes issues in the "admin needs to approve new user registration" feature, if specific conditions are met.

That's because the ACL check, if access to a specific view (in this case the registration view) can be granted now happens before the actual task is performed, redirecting the admin user to the profile page. This PR now prevents the execution of the checks for non-display tasks.

Testing Instructions

  • Create a 5.x site, create a menu item for the user registration with access level set to "public"
  • Configure the site to require user approval by admins
  • Register a new user in the frontend
  • Confirm the registration using the link in the email
  • Click on the confirmation link that the admin receives. It will point to the registration menu item and the task ("registration.activate") and the token will be appended
  • You'll be asked to login using your admin account

Actual result BEFORE applying this Pull Request

You are redirected to the profile page, user is not approved

Expected result AFTER applying this Pull Request

User is approved

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar SniperSister SniperSister - open - 21 Feb 2025
avatar SniperSister SniperSister - change - 21 Feb 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Feb 2025
Category Front End com_users
avatar jjnxpct jjnxpct - test_item - 21 Feb 2025 - Tested successfully
avatar jjnxpct
jjnxpct - comment - 21 Feb 2025

I have tested this item ✅ successfully on 8db42b6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44951.

avatar viocassel viocassel - test_item - 21 Feb 2025 - Tested successfully
avatar viocassel
viocassel - comment - 21 Feb 2025

I have tested this item ✅ successfully on 8db42b6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44951.

avatar QuyTon QuyTon - change - 21 Feb 2025
Status Pending Ready to Commit
Labels Added: bug PR-5.3-dev
avatar QuyTon
QuyTon - comment - 21 Feb 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44951.

avatar Pritams43 Pritams43 - test_item - 22 Feb 2025 - Tested successfully
avatar Pritams43
Pritams43 - comment - 22 Feb 2025

I have tested this item ✅ successfully on 8db42b6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44951.

avatar HLeithner HLeithner - change - 27 Feb 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-02-27 11:31:26
Closed_By HLeithner
Labels Added: RTC
avatar HLeithner HLeithner - close - 27 Feb 2025
avatar HLeithner HLeithner - merge - 27 Feb 2025
avatar HLeithner
HLeithner - comment - 27 Feb 2025

thx

avatar bameag
bameag - comment - 3 Mar 2025

I have tested this item ✅ successfully on 8db42b6

Add a Comment

Login with GitHub to post a comment