RTC Composer Dependency Changed PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
14 Feb 2025

Pull Request for Issue # .

Summary of Changes

This pull request (PR) updates the composed dependency "maximebf/debugbar" from version 1.23.0 to version 1.23.6.

Release notes:

This fixes a few small bugs (which might not be relevant for the CMS core but maybe for 3rd party extensions) and PHP 8.4 deprecations.

There is another PR for 5.3-dev, PR #44902 , which is different to this one here as with version 2 the composer package was renamed.

This will cause merge conflicts for the upmerge from 5.2-dev to 5.3-dev after the 2 PRs will be merged, which have to be resolved by keeping the version from 5.3-dev.

Testing Instructions

Enable "Debug System" in Global Configuration and set "Error Reporting" to "Maximum".

Then use all features of the debug bar.

Change some option of the "System - Debug" plugin, e.g. enable previously disabled options or vice versa, and check the result in the debug bar.

Actual result BEFORE applying this Pull Request

Debug bar works.

Expected result AFTER applying this Pull Request

Debug bar works as before.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar richard67 richard67 - open - 14 Feb 2025
avatar richard67 richard67 - change - 14 Feb 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Feb 2025
Category External Library Composer Change
avatar richard67 richard67 - change - 14 Feb 2025
The description was changed
avatar richard67 richard67 - edited - 14 Feb 2025
avatar alikon alikon - test_item - 14 Feb 2025 - Tested successfully
avatar alikon
alikon - comment - 14 Feb 2025

I have tested this item ✅ successfully on 6362b7b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44901.

avatar viocassel viocassel - test_item - 15 Feb 2025 - Tested successfully
avatar viocassel
viocassel - comment - 15 Feb 2025

I have tested this item ✅ successfully on 6362b7b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44901.

avatar richard67 richard67 - change - 15 Feb 2025
Status Pending Ready to Commit
Labels Added: Composer Dependency Changed PR-5.2-dev
avatar richard67
richard67 - comment - 15 Feb 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44901.

avatar richard67
richard67 - comment - 16 Feb 2025

@alikon @viocassel Could one of you check if we have an issue with dark mode with this PR applied? Without this PR on a clean 5.2-dev, the debug bar doesn't have any dark mode, so it is still bright when the browser is in dark mode. In 5.3-dev it seems we have a problem with incomplete dark mode of the debugbar, see #44902 (comment) (but that happens also on a clean 5.3-dev without that PR). O worry now this PR here could introduce the same in 5.2-dev, but I don't have the time now to test that due to an urgent meeting.

avatar alikon
alikon - comment - 16 Feb 2025

browser chrome in dark mode without pr
image

browser chrome in dark mode with pr

image

avatar LadySolveig LadySolveig - test_item - 16 Feb 2025 - Tested successfully
avatar LadySolveig
LadySolveig - comment - 16 Feb 2025

I have tested this item ✅ successfully on 6362b7b

Dark/Light Mode are now displayed correctly.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44901.

avatar LadySolveig LadySolveig - alter_testresult - 16 Feb 2025 - LadySolveig: Not tested
avatar brianteeman
brianteeman - comment - 16 Feb 2025

@LadySolveig that is impossible as the dark mode changes are not present in this PR

avatar richard67
richard67 - comment - 16 Feb 2025

@brianteeman She wanted to mark the test result in my other PR for 5.3-dev. Meanwhile that's done.

avatar QuyTon QuyTon - change - 21 Feb 2025
Labels Added: RTC
avatar rdeutz rdeutz - change - 27 Feb 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-02-27 13:01:39
Closed_By rdeutz
avatar rdeutz rdeutz - close - 27 Feb 2025
avatar rdeutz rdeutz - merge - 27 Feb 2025

Add a Comment

Login with GitHub to post a comment