Feeling Lucky
PR-5.3-dev
[#44883] - [5.3] Use ?? null coalescing operator and nested isset
- Closed
- 13 Feb 2025
- Medium
- Build: 5.3-dev
- # 44883
- Diff
- janschoenherr:patch-27
User tests: Successful: Unsuccessful:
Use ?? null coalescing operator and nested isset().
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content com_menus Modules Libraries |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-02-13 13:15:16 |
| Closed_By | ⇒ | janschoenherr | |
| Labels |
Added:
PR-5.3-dev
|
||
This PR is also the same with my other PR #44877 (I haven't run the rule in libraries folder yet, want to do it in separate PR for easier reviewing)
Your PR seems missising some possible changes. As we prefer doing the change using rector tool, maybe you can revert the changes in other files and only keep change in the file administrator/components/com_content/src/Model/ArticleModel.php for this PR (the change you made for the file could not be detected by the rector rule I'm using for the PR). Consider that it is just a suggestion, you can keep all the changes here and I will ask maintainer team to see what to do with the two PRs :).