[#44882] - [5.3] Replace calls to dirname(__FILE) with __DIR__
- Fixed in Code Base
- 27 Feb 2025
- Medium
- Build: 5.3-dev
- # 44882
- Diff
- janschoenherr:patch-26
User tests: Successful: Unsuccessful:
Use the __DIR__ constant. It's shorter and doesn't require a function call.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_joomlaupdate Installation |
I don't think there is a difference. WordPress uses __DIR__ in the index.php.
WordPress uses DIR in the index.php
Well, WP doesn't have an option for public folder #40509 but anyways that wasn't really the reason as @joomdonation mentioned it's about compatibility for ancient PHP versions in the app entry points
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-02-13 11:50:49 |
| Closed_By | ⇒ | janschoenherr | |
| Labels |
Added:
PR-5.3-dev
|
||
| Status | Closed | ⇒ | New |
| Closed_Date | 2025-02-13 11:50:49 | ⇒ | |
| Closed_By | janschoenherr | ⇒ |
| Status | New | ⇒ | Pending |
I've reverted the changes in the PHP error messages.
I have tested this item ✅ successfully on 3300441
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44882.
I have tested this item ✅ successfully on 3300441
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44882.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44882.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-02-27 13:16:12 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
RTC
|
||
All these files are the Joomla entry points for the app. I'm not sure if this change will work with the public folder...