[#44878] - [5.3] Use Null Coalescing Assignment Operator For Components
- Fixed in Code Base
- 22 Feb 2025
- Medium
- Build: 5.3-dev
- # 44878
- Diff
- joomdonation:use-null-coalescing-operator-rector-rule
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This PR uses NullCoalescingOperatorRector rector rule to improve components code using ??= operator. This is done automatically by rector, no manual change included.
Testing Instructions
Code review
Actual result BEFORE applying this Pull Request
Works
Expected result AFTER applying this Pull Request
Works, with cleaner, easier to read code
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content com_menus com_users Front End com_contact com_newsfeeds |
| Labels |
Added:
PR-5.3-dev
|
||
Done, thanks @richard67 . It's strange that our PHPCS has special treatment for ??= operator, not sure why it does not want to be aligned in the same way with = operator
I have tested this item ✅ successfully on 7045b5b
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44878.
I have tested this item ✅ successfully on 7045b5b
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44878.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44878.
| Labels |
Added:
RTC
|
||
| Category | Administration com_content com_menus com_users Front End com_contact com_newsfeeds | ⇒ | Administration com_content com_menus com_users Front End com_contact com_newsfeeds Libraries |
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-02-22 11:02:37 |
| Closed_By | ⇒ | HLeithner |
thanks
@joomdonation Could you fix the PHPCS issues listed here? https://ci.joomla.org/joomla/joomla-cms/82216/1/7