RTC PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
13 Feb 2025

Pull Request for Issue # .

Summary of Changes

This PR uses StrContainsRector rector rule to convert code of our components to use str_contains function. This is done automatically by rector, no manual change included.

Testing Instructions

Code review

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works, with cleaner, easier to read code

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomdonation joomdonation - open - 13 Feb 2025
avatar joomdonation joomdonation - change - 13 Feb 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Feb 2025
Category Administration com_associations com_categories com_config com_content com_cpanel com_installer com_joomlaupdate com_languages com_login com_menus com_postinstall com_templates
avatar QuyTon QuyTon - test_item - 13 Feb 2025 - Tested successfully
avatar QuyTon
QuyTon - comment - 13 Feb 2025

I have tested this item ✅ successfully on 8a65582


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44875.

avatar richard67 richard67 - test_item - 15 Feb 2025 - Tested successfully
avatar richard67
richard67 - comment - 15 Feb 2025

I have tested this item ✅ successfully on 8a65582

Carefully reviewed every single change.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44875.

avatar richard67 richard67 - change - 15 Feb 2025
Status Pending Ready to Commit
Labels Added: PR-5.3-dev
avatar richard67
richard67 - comment - 15 Feb 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44875.

avatar LadySolveig LadySolveig - change - 15 Feb 2025
Labels Added: RTC
avatar LadySolveig LadySolveig - change - 16 Feb 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-02-16 00:11:26
Closed_By LadySolveig
avatar LadySolveig LadySolveig - close - 16 Feb 2025
avatar LadySolveig LadySolveig - merge - 16 Feb 2025
avatar LadySolveig
LadySolveig - comment - 16 Feb 2025

Thank you @joomdonation and many thanks also to the diligent testers @QuyTon @richard67 💚 💛 💙 ❤️

Add a Comment

Login with GitHub to post a comment