[#44874] - [5.3] Use str_ends_with for components code
- Fixed in Code Base
- 16 Feb 2025
- Medium
- Build: 5.3-dev
- # 44874
- Diff
- joomdonation:str_ends_with_for_components
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This PR uses StrEndsWithRector rector to convert code of our components to use str_ends_with function. This is done automatically by rector, no manual change included.
Testing Instructions
Code review
Actual result BEFORE applying this Pull Request
Works
Expected result AFTER applying this Pull Request
Works, with cleaner, easier to read code
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_config com_joomlaupdate com_templates |
I have tested this item ✅ successfully on 406fc92
Carefully reviewed every single change.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44874.
I have tested this item ✅ successfully on 406fc92
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44874.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
PR-5.3-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44874.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-02-16 00:12:10 |
| Closed_By | ⇒ | LadySolveig |
Thank you @joomdonation 🥳 and many thanks also to the diligent testers @QuyTon @richard67 💚 💛 💙 ❤️
Thanks !
@joomdonation Does
Code reviewmean to compare the changes in the Files (what i can do) or to read the code if it works well (what i can't do)?