Unit/System Tests PR-5.3-dev Pending

User tests: Successful: 0 Unsuccessful: 0

avatar brianteeman
brianteeman
7 Feb 2025

None of the login tests were working as they had only been tested on http When tested in a real work with https the webauthn plugin is also present and the tests all failed

This PR updates the cypress get identifier to more accurately target the login button

Testing Instructions

run the cypress tests with https

 npx cypress run --spec '.\tests\System\integration\api\com_users\Users.cy.js'
 npx cypress run --spec '.\tests\System\integration\site\components\com_users\Login.cy.js'
 npx cypress run --spec '.\tests\System\integration\site\modules\mod_login\Default.cy.js' 

Actual result BEFORE applying this Pull Request

tests fail with error message
CypressError: cy.click()can only be called on a single element. Your subject contained 2 elements. Pass{ multiple: true } if you want to serially click each element.

Expected result AFTER applying this Pull Request

tests complete successfully

Note

This does not resolve the fact that the cypress tests should be running under https otherwise they are incomplete or risky tests

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar brianteeman brianteeman - open - 7 Feb 2025
avatar brianteeman brianteeman - change - 7 Feb 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Feb 2025
Category JavaScript Unit Tests
avatar brianteeman brianteeman - change - 7 Feb 2025
The description was changed
avatar brianteeman brianteeman - edited - 7 Feb 2025
avatar brianteeman brianteeman - change - 7 Feb 2025
Labels Added: Unit/System Tests PR-5.2-dev
avatar joomla-cms-bot joomla-cms-bot - change - 7 Feb 2025
Category JavaScript Unit Tests Unit Tests Repository Administration com_admin SQL Postgresql com_associations com_banners
avatar brianteeman brianteeman - change - 7 Feb 2025
Title
[5.2] cypress login tests
[5.3] cypress login tests
avatar brianteeman brianteeman - edited - 7 Feb 2025
avatar joomla-cms-bot joomla-cms-bot - change - 7 Feb 2025
Category Unit Tests Repository Administration com_admin SQL Postgresql com_associations com_banners JavaScript Unit Tests
avatar laoneo
laoneo - comment - 7 Feb 2025

Thanks. As soon as we are green here, it will be merged. Despite the fix, you discovered a bigger issue and we should change our tests to https, as in #44835, as this is nowadays the standard.

avatar laoneo laoneo - change - 7 Feb 2025
Title
[5.3] cypress login tests
[5.3] Fix the selector in login tests when running on https
avatar laoneo laoneo - edited - 7 Feb 2025
avatar laoneo laoneo - change - 7 Feb 2025
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-02-07 12:58:12
Closed_By laoneo
Labels Added: PR-5.3-dev
Removed: PR-5.2-dev
avatar laoneo laoneo - close - 7 Feb 2025
avatar laoneo laoneo - merge - 7 Feb 2025
avatar brianteeman
brianteeman - comment - 7 Feb 2025

thanks

Add a Comment

Login with GitHub to post a comment