No Code Attached Yet a11y
avatar angieradtke
angieradtke
6 Feb 2025

Hi

had contact to a screenreader-user

Issue:

Backend: Tabs and Tabpanel can be operated using the arrow buttons (OK), but the tabs are also in the focus order (tab order). Only the selected tab may be in the focus order. When I tab through, each tab is "selected", but the selected tab is also "expanded".
We are using the the wrong aria-attributes for the tab-buttons and the tabindex for the button is is not set.

tab-button should have : 'aria-selected instead of aria-expanded (for accordion-button correct) and we need to set the tabindex.

tabObj.accordionButton.removeAttribute('aria-disabled'); tabObj.tabButton.setAttribute('aria-selected', false); tabObj.tabButton.setAttribute('tabindex', -1) ;

This we can change in \media\vendor\joomla-custom-elements\joomla-tab.js

``

avatar angieradtke angieradtke - open - 6 Feb 2025
avatar joomla-cms-bot joomla-cms-bot - change - 6 Feb 2025
Labels Added: No Code Attached Yet a11y
avatar joomla-cms-bot joomla-cms-bot - labeled - 6 Feb 2025
avatar angieradtke angieradtke - change - 6 Feb 2025
The description was changed
avatar angieradtke angieradtke - edited - 6 Feb 2025
avatar angieradtke
angieradtke - comment - 6 Feb 2025

Fixed Js-Files as text-file attached, because I can not find this file in the build -folder to make pull request .-(

joomla-tab.txt

avatar angieradtke angieradtke - change - 6 Feb 2025
The description was changed
avatar angieradtke angieradtke - edited - 6 Feb 2025
avatar angieradtke angieradtke - change - 6 Feb 2025
Title
Tabs and tabpanel -> wrong aria, and missing tabindex
Backend: Tabs and tabpanel -> wrong aria, and missing tabindex
avatar angieradtke angieradtke - edited - 6 Feb 2025
avatar angieradtke angieradtke - change - 6 Feb 2025
The description was changed
avatar angieradtke angieradtke - edited - 6 Feb 2025
avatar angieradtke angieradtke - change - 6 Feb 2025
The description was changed
avatar angieradtke angieradtke - edited - 6 Feb 2025
avatar angieradtke angieradtke - change - 6 Feb 2025
The description was changed
avatar angieradtke angieradtke - edited - 6 Feb 2025
avatar richard67
richard67 - comment - 6 Feb 2025

Fixed Js-Files as text-file attached, because I can not find this file in the build -folder to make pull request .-(

@angieradtke Well that's because joomla-custom-elements is an NPM dependency. The JS would need to be fixed upstream, and when merged there it would need to make a new release of the joomla-custom-elements and then make a PR in this repo here to update that dependency.

The upstream repository should be this one: https://github.com/joomla-projects/custom-elements

With which version did you observe the issue? 5.2.3? Or 5.3-dev?

avatar angieradtke
angieradtke - comment - 6 Feb 2025

? 5.2.3

Yes 5.2.3

avatar angieradtke
angieradtke - comment - 6 Feb 2025

I have tried the pull request again, please check if this is correct? Thank you very much .-)
joomla-projects/custom-elements#242

avatar chmst
chmst - comment - 7 Feb 2025

I have tested this item successfully. It cannot be tested as usual.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44831.

avatar chmst
chmst - comment - 8 Feb 2025

#44831 (comment) is merged.

avatar richard67
richard67 - comment - 8 Feb 2025

Well I think it would need a new release or tag upstream before we can fetch that into the CMS with a new PR.

Add a Comment

Login with GitHub to post a comment