Feature PR-5.3-dev Pending

User tests: Successful: 0 Unsuccessful: 0

avatar joomdonation
joomdonation
6 Feb 2025

Pull Request for Issue # .

Summary of Changes

This PR makes several improvements to System - SEF plugin code :

  • Add missing $event parameter to event listener methods.
  • Use application object $app from $event instead of using the one passed from plugin service provider when it is available

Testing Instructions

  • Use Joomla 5.3 nightly build
  • Make sure System - SEF plugin is enabled
  • Access to frontend of your site

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works, with better code

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomdonation joomdonation - open - 6 Feb 2025
avatar joomdonation joomdonation - change - 6 Feb 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Feb 2025
Category Front End Plugins
avatar joomdonation joomdonation - change - 6 Feb 2025
The description was changed
avatar joomdonation joomdonation - edited - 6 Feb 2025
avatar laoneo laoneo - change - 6 Feb 2025
Labels Added: PR-5.3-dev
avatar Fedik Fedik - test_item - 9 Feb 2025 - Tested successfully
avatar Fedik
Fedik - comment - 9 Feb 2025

I have tested this item ✅ successfully on 658de8a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44830.

avatar viocassel viocassel - test_item - 9 Feb 2025 - Tested successfully
avatar viocassel
viocassel - comment - 9 Feb 2025

I have tested this item ✅ successfully on 658de8a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44830.

avatar laoneo laoneo - change - 9 Feb 2025
Labels Added: Feature
avatar laoneo laoneo - change - 9 Feb 2025
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-02-09 19:45:47
Closed_By laoneo
avatar laoneo laoneo - close - 9 Feb 2025
avatar laoneo laoneo - merge - 9 Feb 2025

Add a Comment

Login with GitHub to post a comment