PR-5.3-dev Pending

User tests: Successful: 0 Unsuccessful: 0

avatar joomdonation
joomdonation
5 Feb 2025

Pull Request for Issue # .

Summary of Changes

Follow up for the merged PR #43427 . Remove the return true; statement because the method should have void return type

Testing Instructions

Can be merged by review as discussed in the PR. Ping @laoneo

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works

avatar joomdonation joomdonation - open - 5 Feb 2025
avatar joomdonation joomdonation - change - 5 Feb 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Feb 2025
Category Front End Plugins
avatar joomdonation
joomdonation - comment - 5 Feb 2025

Should we not just return here?

No, this statement is at the end of method, so adding return; here is useless.

avatar laoneo
laoneo - comment - 5 Feb 2025

Ah now I see it, thought it is at the end of an "if" block.

avatar laoneo laoneo - change - 5 Feb 2025
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-02-05 08:06:48
Closed_By laoneo
Labels Added: PR-5.3-dev
avatar laoneo laoneo - close - 5 Feb 2025
avatar laoneo laoneo - merge - 5 Feb 2025
avatar laoneo
laoneo - comment - 5 Feb 2025

Thanks!

avatar joomdonation
joomdonation - comment - 5 Feb 2025

Thanks !

Add a Comment

Login with GitHub to post a comment