Feeling Lucky
PR-5.3-dev
[#44820] - [5.3] Remove useless return statement
- Fixed in Code Base
- 5 Feb 2025
- Medium
- Build: 5.3-dev
- # 44820
- Diff
- joomdonation:remove_useless_return_command
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Follow up for the merged PR #43427 . Remove the return true; statement because the method should have void return type
Testing Instructions
Can be merged by review as discussed in the PR. Ping @laoneo
Actual result BEFORE applying this Pull Request
Works
Expected result AFTER applying this Pull Request
Works
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
laoneo
- comment
- 5 Feb 2025
Ah now I see it, thought it is at the end of an "if" block.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-02-05 08:06:48 |
| Closed_By | ⇒ | laoneo | |
| Labels |
Added:
PR-5.3-dev
|
||
laoneo
- comment
- 5 Feb 2025
Thanks!
joomdonation
- comment
- 5 Feb 2025
Thanks !
No, this statement is at the end of method, so adding return; here is useless.