[#44819] - [5.3] Convert administrator mod_feed to service provider
- Fixed in Code Base
- 12 Feb 2025
- Medium
- Build: 5.3-dev
- # 44819
- Diff
- joomlaweby:mod_feed_admin
User tests: Successful: Unsuccessful:
Summary of Changes
Converts the administrator feed module to service provider.
Testing Instructions
- Make sure you have administrator module mod_feed published and configured
- You should see module output
Actual result BEFORE applying this Pull Request
Module works as expected
Expected result AFTER applying this Pull Request
Module works same way as before applying pull request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Administration |
I have tested this item ✅ successfully on bd7ef71
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44819.
| Labels |
Added:
PR-5.3-dev
|
||
I've restored the previous 2 human test results in the issue tracker as the commit which had invalidated the test count were only clean branch updates and a change in code comments.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44819.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Pending |
Back to pending due to previous review comment.
@joomlaweby Could you implement @laoneo 's suggestions? That would be really appreciated.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44819.
Back to pending due to previous review comment.
@joomlaweby Could you implement @laoneo 's suggestions? That would be really appreciated.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44819.
Yes, of course...I will make it :-)
| Labels |
Added:
Updates Requested
Removed: RTC |
||
@fgsw @viocassel Could you test again? Thanks in advance.
I have tested this item ✅ successfully on e363948
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44819.
| Labels |
Removed:
Updates Requested
|
||
I have tested this item ✅ successfully on 824dee1
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44819.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44819.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-02-12 11:36:50 |
| Closed_By | ⇒ | laoneo |
Thanks!
Thanks to everybody for reviewing and testing!
I have tested this item ✅ successfully on bd7ef71
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44819.