Joomla! Issue Tracker | Joomla! CMS #44784 - [5.2] Tag Router: Allow numeric/CSV IDs (Regression)

RTC Release Blocker bug PR-5.2-dev

Fixed in Code Base
3 Feb 2025
Medium
Build: 5.2-dev
# 44784
Diff
Hackwar:5.2-tags-routing-regression

Success

Success continuous-integration/appveyor/branch AppVeyor build succeeded Details
Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
Success Download Prebuilt packages are available for download. Details
Success continuous-integration/drone/pr Build is passing Details
Success continuous-integration/drone/push Build is passing Details

User tests: Successful: Unsuccessful:

Hackwar
26 Jan 2025

Pull Request for Issue #44703.

Summary of Changes

With Joomla 5.2.3 and PR #44540 the tag router was changed to rather throw a 404 when the URL was falsely extended by random segments. This unfortunately introduced a regression, where numeric segments and comma-separated lists of numeric IDs were treated as 404s. While by default all tag URLs should only produce alias-based URLs, we apparently have numeric URLs out there, which are now falsely are marked as broken. This PR checks for numeric IDs and for comma-separated IDs in the URL.

Testing Instructions

Your site needs at least 2 tags (A and B) and content items which have once A, once B and once A and B assigned to them. You should also have a menu item which points to com_tags. The type is pretty much irrelevant. For ease of description A has ID 1 and B has ID 2. The menu item has the alias tagmenu.
Open /component/tags/tag/a
Open /component/tags/tag/b
Open /component/tags/tag/a/b
Open /component/tags/tag/1
Open /component/tags/tag/2
Open /component/tags/tag/1,2
Open /component/tags/tag/1/2
Open /tagmenu/a
Open /tagmenu/b
Open /tagmenu/1
Open /tagmenu/2
Open /tagmenu/1,2
Open /tagmenu/1/2
Open /component/tags/tag/a/2
Open /component/tags/tag/a/1,2
Open /tagmenu/a/2

Actual result BEFORE applying this Pull Request

Cases 2,3,4,9,10 return a page, all the rest throws a 404.

Expected result AFTER applying this Pull Request

Cases 15,16,17 throw a 404, the rest returns a successfull page.

Link to documentations

Please select:

Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed

a9b93b6 26 Jan 2025

Tag Router: Allow numeric/CSV IDs (Regression)

Hackwar - open - 26 Jan 2025

Hackwar - change - 26 Jan 2025

Status

New

⇒

Pending

joomla-cms-bot - change - 26 Jan 2025

Category

⇒

com_tags Front End

brianteeman - comment - 29 Jan 2025

Should there be system tests for this?

exlemor - test_item - 29 Jan 2025 - Tested successfully

exlemor - comment - 29 Jan 2025

I have tested this item ✅ successfully on a9b93b6

I have successfully tested this. (BUT check notes below)

Not being 100% sure if this matters/is expected, but with the Patch turned on for:

Open /tagmenu/1
Open /tagmenu/2
Open /tagmenu/1,2
Open /tagmenu/1/2

There was no title (h1) in Bold above the Filter/Clear box:

(Enter Part of Title) Filter/Clear box
Joomla
Millions
Typography

like you have for:

Open /component/tags/tag/a
Open /component/tags/tag/b
Open /component/tags/tag/a/b
Open /component/tags/tag/1
Open /component/tags/tag/2
Open /component/tags/tag/1,2
Open /component/tags/tag/1/2

Apple
(Enter Part of Title) Filter/Clear box
Joomla
Millions
Typography

if that is expected than it's perfect.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44784.}

(I added screenshots via Github)

Hackwar - comment - 30 Jan 2025

Hello @exlemor, thank you for testing this. Yes, the behavior is expected, since the /component/tags has no menu item attached to it and thus no configuration for the page.