[#44783] - [5.2] Tag Router: Allow numeric/CSV IDs (Regression)
- Closed
- 26 Jan 2025
- Medium
- Build: 5.2-dev
- # 44783
- Diff
- joomla:5.2-tags-routing-regression
- Pending continuous-integration/drone/push Build is running Details
- Success continuous-integration/appveyor/branch AppVeyor build succeeded Details
- Success Download Prebuilt packages are available for download. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #44703.
Summary of Changes
With Joomla 5.2.3 and PR #44540 the tag router was changed to rather throw a 404 when the URL was falsely extended by random segments. This unfortunately introduced a regression, where numeric segments and comma-separated lists of numeric IDs were treated as 404s. While by default all tag URLs should only produce alias-based URLs, we apparently have numeric URLs out there, which are now falsely are marked as broken. This PR checks for numeric IDs and for comma-separated IDs in the URL.
Testing Instructions
- Your site needs at least 2 tags (A and B) and content items which have once A, once B and once A and B assigned to them. You should also have a menu item which points to com_tags. The type is pretty much irrelevant. For ease of description A has ID 1 and B has ID 2. The menu item has the alias
tagmenu. - Open /component/tags/tag/a
- Open /component/tags/tag/b
- Open /component/tags/tag/a/b
- Open /component/tags/tag/1
- Open /component/tags/tag/2
- Open /component/tags/tag/1,2
- Open /component/tags/tag/1/2
- Open /tagmenu/a
- Open /tagmenu/b
- Open /tagmenu/1
- Open /tagmenu/2
- Open /tagmenu/1,2
- Open /tagmenu/1/2
- Open /component/tags/tag/a/2
- Open /component/tags/tag/a/1,2
- Open /tagmenu/a/2
Actual result BEFORE applying this Pull Request
Cases 2,3,4,9,10 return a page, all the rest throws a 404.
Expected result AFTER applying this Pull Request
Cases 15,16,17 throw a 404, the rest returns a successfull page.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | com_tags Front End |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-01-26 21:22:34 |
| Closed_By | ⇒ | Hackwar | |
| Labels |
Added:
Release Blocker
bug
PR-5.2-dev
|
||
Accidentally pushed this to the main repo. Closing and reopening as #44784 again.