Joomla! Issue Tracker | Joomla! CMS #44782 - [6.1] Fix $dirname description

PR-5.3-dev

Pending
Medium
Build: 5.3-dev
# 44782
Diff
QuyTon:text-dirname

Pending

User tests: Successful: Unsuccessful:

QuyTon
26 Jan 2025

Testing Instructions

Code review.

joomla-cms/libraries/src/Form/Field/TextField.php

Lines 64 to 70 in 88371b1

    
               /** 
        
                * The name of the form field direction (ltr or rtl). 
        
                * 
        
                * @var    string 
        
                * @since  3.2 
        
                */ 
        
               protected $dirname;

Syntax should be name.dir but incorrectly changed in 3f4285e

a1634c5 26 Jan 2025

Fix variable description

QuyTon - open - 26 Jan 2025

QuyTon - change - 26 Jan 2025

Status

New

⇒

Pending

joomla-cms-bot - change - 26 Jan 2025

Category

⇒

Layout

9bd316c 26 Jan 2025

Update text.php

QuyTon - change - 26 Jan 2025

Labels

Added: PR-5.3-dev

brianteeman - comment - 26 Jan 2025

I dont think this is correct. see

joomla-cms/libraries/src/Form/Field/TextField.php

Lines 197 to 199 in 88371b1

    
           // Set the dirname. 
        
           $dirname       = ($dirname === 'dirname' || $dirname === 'true' || $dirname === '1'); 
        
           $this->dirname = $dirname ? $this->getName($this->fieldname . '_dir') : false;

2811636 3 Feb 2025

Fix syntax

joomla-cms-bot - change - 3 Feb 2025

Category

Layout

⇒

Layout Libraries

QuyTon - change - 3 Feb 2025

The description was changed

QuyTon - edited - 3 Feb 2025

QuyTon - change - 3 Feb 2025

The description was changed

QuyTon - edited - 3 Feb 2025

HLeithner - comment - 7 May 2025

shouldn't <input dirname=""> be rtl or ltr ?! but $this->getName($this->fieldname . '_dir'); returns a fieldname_dir?

brianteeman - comment - 7 May 2025

shouldn't be rtl or ltr

always ltr

HLeithner - comment - 8 Oct 2025

@QuyTon can you give some testing instructions and explain what is affected? 3rd party extensions? Browsers? Also are you plain to finish this?

I would also like to clarify if this is a b/c break or not.

HLeithner - change - 8 Oct 2025

Title

…

[~~5.3~~] Fix $dirname description

[6.1] Fix $dirname description

HLeithner - edited - 8 Oct 2025

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#44782] - [6.1] Fix $dirname description

Testing Instructions

Add a Comment

	/**
	* The name of the form field direction (ltr or rtl).
	*
	* @var string
	* @since 3.2
	*/
	protected $dirname;

	// Set the dirname.
	$dirname = ($dirname === 'dirname' \|\| $dirname === 'true' \|\| $dirname === '1');
	$this->dirname = $dirname ? $this->getName($this->fieldname . '_dir') : false;