Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#44782] - [5.3] Fix $dirname description

PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar QuyTon
QuyTon
26 Jan 2025

Testing Instructions

Code review.

joomla-cms/libraries/src/Form/Field/TextField.php

Lines 64 to 70 in 88371b1

/**
* The name of the form field direction (ltr or rtl).
*
* @var string
* @since 3.2
*/
protected $dirname;

Syntax should be name.dir but incorrectly changed in 3f4285e

avatar QuyTon QuyTon - open - 26 Jan 2025
avatar QuyTon QuyTon - change - 26 Jan 2025
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Jan 2025
Category ⇒ Layout
avatar QuyTon QuyTon - change - 26 Jan 2025
Labels Added: PR-5.3-dev
avatar brianteeman
brianteeman - comment - 26 Jan 2025

I dont think this is correct. see

joomla-cms/libraries/src/Form/Field/TextField.php

Lines 197 to 199 in 88371b1

// Set the dirname.
$dirname = ($dirname === 'dirname' || $dirname === 'true' || $dirname === '1');
$this->dirname = $dirname ? $this->getName($this->fieldname . '_dir') : false;

avatar joomla-cms-bot joomla-cms-bot - change - 3 Feb 2025
Category Layout ⇒ Layout Libraries
avatar QuyTon QuyTon - change - 3 Feb 2025
The description was changed
avatar QuyTon QuyTon - edited - 3 Feb 2025
avatar QuyTon QuyTon - change - 3 Feb 2025
The description was changed
avatar QuyTon QuyTon - edited - 3 Feb 2025
avatar HLeithner
HLeithner - comment - 7 May 2025

shouldn't <input dirname=""> be rtl or ltr ?! but $this->getName($this->fieldname . '_dir'); returns a fieldname_dir?

avatar brianteeman
brianteeman - comment - 7 May 2025

shouldn't be rtl or ltr

always ltr

Add a Comment

Login with GitHub to post a comment