[#44780] - [5.2][Cypress] Minor Code Simplification
- Fixed in Code Base
- 26 Jan 2025
- Medium
- Build: 5.2-dev
- # 44780
- Diff
- muhme:cypress-minor-code-cleanup-sef-test
User tests: Successful: Unsuccessful:
Summary of Changes
Since setSefDefaults already returns a Promise (which Cypress understands and waits for), there's no need to wrap it in an anonymous function. Therefore, the code has been simplified to make it prettier and a little more suitable for the next copy&paste.
Thanks to @laoneo for the hint.
Testing Instructions
Run Joomla System test plugins/system/sef/SefPlugin.cy.js with Cypress.
Actual result BEFORE applying this Pull Request
Joomla System test SefPlugin.cy.js is running w/o errors.
Expected result AFTER applying this Pull Request
Joomla System test SefPlugin.cy.js is still running w/o errors.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Unit Tests |
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-01-26 10:55:08 |
| Closed_By | ⇒ | laoneo | |
| Labels |
Added:
Unit/System Tests
PR-5.2-dev
|
||
Thanks!