User tests: Successful: 0 Unsuccessful: 0
3rd try for inline SVG icons.
Prior work:
[ name => svgCode ]
) with all the FA iconsI Just covered few icons so that it's easy for any reviewers to check what is happening.
The icon part could be done with a Layout for even easier usage.
I picked the show/hide password to showcase the JS changes (supports both font/inline svg icons)
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_cpanel Modules JavaScript Repository NPM Change Layout Libraries Front End Plugins |
Could move it to the Document class or WAM. Fwiw first or second try was on the document class anyways this is implementation details could move the code around
I'm not in favor doing this (or anyting else) with the htmlhelper, it's a thing that should be removed and directly done in the webassetmanager or document it self. Didn't looked at the svg implementation it self, will do that later, at least it would be cool to have this if it's working.