Tests are failing as the required framework is absent, some help here will be nice ;)

dgt41#6 help is at hand :)

@wilsonge Thanks for the unit tests code About tooltips: Yes something funny happening there I think is got to do with this code

echo JHtml::tooltipText('COM_CHECKIN_FILTER_SEARCH_DESC’);

Which I think is useless, just a class and a JText::_(’TOOLTIP_TEXT’); is all needed.

I am investigating the (spaghetti code) and hopefully I’ll come up with some changes…

The thing is that you can call tooltips in 2 ways:

JHtml::('bootstrap.tooltip');

And

JHtml::('behavior.tooltip');

The last one needs mootools (legacy staff), but is not used in admin or front end any more...

Travis fails here JHtmlBehaviorTest::testTooltip and here JHtmlBehaviorTest::testNoFrames
But I guess he still expects to find mootools or he doesn’t like jQuery… ????

Executive summary:

First of all don’t be afraid of the number of files this PR touches.
The changes in all files are straight forward and are grouped in two categories:

• remove unnecessary calls JHtml::_('behavior.framework’); in
  libraries/cms/html/behavior.php
  libraries/cms/toolbar/button/confirm.php
  libraries/cms/toolbar/button/help.php
  libraries/cms/toolbar/button/standard.php
  But also adding the call, for the time being, at layouts/joomla/toolbar/base.php for not breaking B/C

• replace all the document.id(’some-form’) in edit views in administrator with native javascript document.getElementById(’some-form’) as suggested by @fedik

• Update the ut tests/unit/suites/libraries/cms/html/JHtmlBehaviorTest.php. @wilsonge Thanks for that!!

So although many changes applied the functionality remains the same, but this will ease our way to drop mootools down the road…

@dgt41 you mean this #L56-L86 ?
yes there a lot mootools
vanilla will be a bit complicated there, but jQuery should be good

and maybe better make this in separate pull, cause there need not a trivial changes

At least mootools is properly called here https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_menus/views/item/tmpl/edit.php#L15 so no rush to drop that, yet!

Update as more tests was conducted:
On behavior.php there are some calls to mootools except from the JHtml_(‘behavior.framework’);
the first flag true should be false in these occasions:
https://github.com/dgt41/joomla-cms/blob/mootools/libraries/cms/html/behavior.php#L215
https://github.com/dgt41/joomla-cms/blob/mootools/libraries/cms/html/behavior.php#L651
and
https://github.com/dgt41/joomla-cms/blob/mootools/libraries/cms/html/behavior.php#L394
The last one multiselect uses mootools code for the initialization call

"window.addEvent('domready', function() {
                new Joomla.JMultiSelect('" . $id . "');
            });”

which obviously has to become jquery (or vanilla)

On Global Configuration is mootools-more and mootools-core still loaded

Yes, which is correct because there is a modal window there, and modal is a mootools script. Unless somebody comes up with new code for modal.js there is nothing more that we can do about it.

PS the modal in @: Offline Image on the select button

do you know the code to show mootools-core. Because its also loaded on sysinfo, I can't find the mootools loading

You can comment this line dgt41@4ce723d#diff-22d356c612b1a6ccbefdcdd05cd81a88R12
But this will most probably break all third party components.

In most pages motools load because of the toolbar buttons removing that will break B/C

@810 I just pushed some corrections that are more appropriate for toolbar, please try...

@dgt41 looks good for me, but is it b/c proof?

No, we don’t want to totally remove mootools. Basically this is a clean up and preparing the code for jquery. But even if I provide all the code that is needed for core components, mootools unfortunately cannot go away because almost all code from 3PD is still using it. This is not a way to TOTALLY REMOVE mootools as this cannot be done in 3.x. But will ease the way for 4.x. And yes it should be 100% safe.

@dgt41 good points and well done. Indeed it will be good to completely move all core code to jQuery. Mootools can stay in the package and be used by 3rd parties as they see fit. At least it will be ready for removal when Joomla 4 comes around.

@dgt41 there #4517 for menu editing

@Fedik Nice! ???? Patch tester clash those 2 PRs so I have to copy paste your code. Will do it later. Thanks

Closing this one, as I break it to two separate and easier to review PRs.