User tests: Successful: Unsuccessful:
This is an idea I had, and just want to see some opinions/improvements about it.
When installing a fresh Joomla! the first thing is the language selector. But most of the time, you don't need to change the language as it's auto discovered. So this PR minimize the box and moved the selector to a dialog popup. It also fixes some autodiscoveries when e.g. only "de/fr/nl" is submitted by the browser (Firefox does this) to discover "de-DE/fr-FR/nl-NL".
Language selector on top
Language selector minimized
Status | New | ⇒ | Pending |
Category | ⇒ | Installation Language & Strings JavaScript NPM Change Libraries |
Labels |
Added:
Language Change
NPM Resource Changed
PR-5.3-dev
|
I like the idea.
For A11y: The link must have an underline.
It is not obvious that clicking on the current language name will let you change the language. This is an accessibility failure.
The label could be "Change the currnet language "
Title |
|
@bembelimen Gary and I would really like to see this in 6, as it makes installation a bit quicker and more intuitive.
One thought we had was to have the as a change symbol to draw the eye to this being where you can change the language.
The main issue I see is that when you are in a language you dont understand its not possible to read to switch the language so a symbol could be helpful.
Another candidate would be
@chmst makes the good point that the link should be underlined, this helps to draw the eye to functionality as well
What can we do to support you with this feature?
Labels |
Added:
PR-6.0-dev
Removed: PR-5.3-dev |
I've improved the code & screenshots, hope this helps.
Ooh, I like that. The simple addition of an icon really helps to make the point, even if you're looking at it in a language you're not familiar with. Thanks for the work you've put into this.
Looks good but your button needs an additional Text
like
<span class="visually-hidden">Change the installation language</span>
joomla-projects/joomla-cypress#41 is needed for fixing the tests
Looks good but your button needs an additional Text
like
<span class="visually-hidden">Change the installation language</span>
Added the text, thx.
@bembelimen Close #24481?
@bembelimen I know were waiting for cypress fix, is this PR ready test or anything else todo?
Ready to test
@bembelimen Close #24481?
No, although I like the idea of the issue
I went to test this as part of late day PBF with Olivier via screenshare and we think there are a couple of small improvements still needed:
IF you FIRST click the arrows to change the language which was my and Olivier's first reaction, there is a red message that comes up under the Enter the name of your Joomla site. * which says: "Please fill in this field." which felt out of place/odd, and moreover, if you re-click on the same arrow symbol, it gives you the modal for language selection... which is inconsistent behavior... EITHER, you block access to the language choice modal until the person enters the site name (even though we don't understand why that would be) OR you give access directly to the language choice modal with having to type in site name...
the placement of the minimized language selector feels odd visually as it is floating sort of left justified underneath the white shadow box of the site name/installation. It would be better inside the white box of the site name/installation... and why not before the site name?
I really like this improvement. My initial thought was: ok, I don't want to mess the install up, I will change the language first so I don't forget. So, I clicked on the small button for that effect and I ran into the same issue as Emmanuel.
Note that one should go in the order of the fields... but you know how unpredictable users can be...
:-)
I had an idea about the box:
I like this as it's cutting down the choices needed to set up a site and anything to make the install easier for the majority is good