RTC Language Change bug PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
9 Jan 2025

Pull Request for Issue #39328 .

Summary of Changes

  1. the htmlbody string is sanitized by the html editor when it is loaded which is why {messages} is moved outside of the table. This PR moves {messages} to wrap the table instead of the row to avoid this sanitization and make the email work
  2. {messages} is missing from the params field in the database which is why it doesnt appear in the list of tags to insert and thus without that tag nothing is in the email

Testing Instructions Part 1

Set Mail Templates to send mail as html
Enable receiving action log emails for your user and do something to trigger an email eg saving an article
image

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Testing Instructions Part 2

Open the User Actions Log: Notification Mail template

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

NOTE: If a user has already saved a User Actions Log: Notification Mail template they will need to press the reset HTML Body button.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar brianteeman brianteeman - open - 9 Jan 2025
avatar brianteeman brianteeman - change - 9 Jan 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Jan 2025
Category SQL Administration com_admin Postgresql Language & Strings Installation
avatar alikon alikon - test_item - 24 Jan 2025 - Tested successfully
avatar alikon
alikon - comment - 24 Jan 2025

I have tested this item ✅ successfully on 9f3f7d3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44709.

avatar QuyTon QuyTon - test_item - 24 Jan 2025 - Tested successfully
avatar QuyTon
QuyTon - comment - 24 Jan 2025

I have tested this item ✅ successfully on 9f3f7d3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44709.

avatar QuyTon QuyTon - change - 24 Jan 2025
Status Pending Ready to Commit
Labels Added: bug Language Change PR-5.2-dev
avatar QuyTon
QuyTon - comment - 24 Jan 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44709.

avatar QuyTon QuyTon - change - 24 Jan 2025
Labels Added: RTC
avatar Hackwar
Hackwar - comment - 26 Jan 2025

I'm unhappy with moving the MESSAGES outside of the table, since it means it is duplicating the complete table instead of just the row, but it seems right now this is the only solution we have. Merging this now. Thank you!

avatar brianteeman
brianteeman - comment - 26 Jan 2025

@Hackwar I was never able to get more than one message in an email

avatar Hackwar Hackwar - change - 26 Jan 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-01-26 17:56:01
Closed_By Hackwar
avatar Hackwar Hackwar - close - 26 Jan 2025
avatar Hackwar Hackwar - merge - 26 Jan 2025

Add a Comment

Login with GitHub to post a comment