Unit/System Tests PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
3 Jan 2025

Summary of Changes

add test for console command


- php cli/joomla site:up
- php cli/joomla site:down

Testing Instructions

npm cypress run --spec tests/System/integration/cli/SiteUpDown.cy.js

Actual result BEFORE applying this Pull Request

N/A

Expected result AFTER applying this Pull Request

conole command tested

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar alikon alikon - open - 3 Jan 2025
avatar alikon alikon - change - 3 Jan 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Jan 2025
Category JavaScript Unit Tests
9dc61d7 3 Jan 2025 avatar alikon cs
avatar alikon alikon - change - 3 Jan 2025
Labels Added: Unit/System Tests PR-5.3-dev
avatar muhme
muhme - comment - 4 Jan 2025

From my perspective, testing the Joomla command-line tool client within Joomla System Tests is not ideal. This approach reintroduces a dependency that was intentionally removed by #44656 for valid reasons. Are Joomla System Tests not exclusively meant for testing the website frontend and backend? Could we consider having separate tests dedicated to the command-line tool instead?

avatar alikon
alikon - comment - 4 Jan 2025

Are Joomla System Tests not exclusively meant for testing the website frontend and backend?

i dont think so, in joomla we have something like 4 applications:

  • frontend
  • backend
  • websrvices
  • cli

so i consider a good pratice to test all of them with the same toolchian

avatar alikon alikon - change - 4 Jan 2025
The description was changed
avatar alikon alikon - edited - 4 Jan 2025
avatar alikon alikon - change - 4 Jan 2025
Title
site-up-&-down
[5.3][cypress] test console command site:up & site:down
avatar alikon alikon - edited - 4 Jan 2025
avatar heelc29 heelc29 - test_item - 8 Jan 2025 - Tested successfully
avatar heelc29
heelc29 - comment - 8 Jan 2025

I have tested this item ✅ successfully on f6facfa


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44683.

avatar laoneo laoneo - change - 9 Jan 2025
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-01-09 06:46:24
Closed_By laoneo
avatar laoneo laoneo - close - 9 Jan 2025
avatar laoneo laoneo - merge - 9 Jan 2025
avatar laoneo
laoneo - comment - 9 Jan 2025

Thanks!

Add a Comment

Login with GitHub to post a comment