Thank you @alikon for your contribution and for adding System Tests for the new REST API category history functionality.

Is it possible to also test PATCH and DELETE requests in the System Tests after testing GET?

I would test in parallel with curl or postman and document this as the mentioned System Test spec is already included in the CI. And would ask around how to proceed with the documentation, e.g. there is no POST as the history entries are only created implicit.

yes, of course
but i'll be slow, i'm short in free time currently

@alikon We have discussed this PR among release managers and decided to move it to 6.0-dev as it's a new feature, so I've just rebased your PR. Now it shows 2 unrelated changes, but these will disappear after the next upmerge and branch update.

I have tested this item 🔴 unsuccessfully on 6ceaaf1

I have tested with current 6.0-dev and curl command line (script and output will be attached to the PR)

• ✅ With wrong API token
  • ✅ GET /v1/content/category/:id/contenthistory -> 401 "Unauthorized" with error "Forbidden"
  • ✅ PATCH /v1/content/category/:id/contenthistory/keep -> 401 "Unauthorized" with error "Forbidden"
  • ✅ DELETE /v1/content/category/:id/contenthistory -> 401 "Unauthorized" with error "Forbidden"
• ✅ GET /v1/content/category/:id/contenthistory -> 200 "OK" and returning the entry in JSON format
• ✅ PATCH /v1/content/category/:id/contenthistory/keep -> 200 "OK" and empty return
  • ✅ And verified next GET has "keep_forever" : 1 set
• ❌ DELETE /v1/tags/:id/contenthistory -> 204 "No Content" end no content returned
  • database entry is still present
  • second delete returns again 204 and database entry still exists
• ❌ Non existing entries, expected is e.g. 404 "Not Found"
  • GET /v1/content/category/4711/contenthistory -> 200 "OK" and json structure with self link and empty data and empty meta
  • PATCH /v1/content/category/4711/contenthistory/keep -> 400 "Bad Request" with JSON error "Changed the keep forever value for a history version."
  • DELETE /v1/content/category/4711/contenthistory -> 500 "Internal Server Error" with JSON error "RuntimeException"
• ✅ System Tests for GET, PATCH and DELETE are existing and working
  • Perhaps, they could be extened for testing non-existing :id? Trying to delete the contenthistory entry a second time would also show the contenthistory entry was deleted.

Not tested was the following. Should this or something elso be tested next time?

• PATCH with malformed JSON
• PATCH with unsupported fields

The database has been checked in parallel and regardless of this PR, the content history entries for content category are not deleted when the content category is deleted and I will extend the issue #45584 for this.

Regardless of this PR, testing also found that attempting to delete an not-trashed content category via the API results in 500, and I will create an issue for that.

There is are difference in the endpoints using singular and plural with #44669 is this intended? For example:

• GET /tags/:id/contenthistory
• GET /content/category/:id/contenthistory

  ---

  _{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44670.}

Files

• api_contentcategory_contenthistory_test.sh.txt
• api_contentcategory_contenthistory_test.log