Feeling Lucky
RTC
PR-5.2-dev
[#44659] - [5.2] Build process: Change Dart-Sass to new API
- Fixed in Code Base
- 19 Jan 2025
- Medium
- Build: 5.2-dev
- # 44659
- Diff
- Hackwar:5.2-scss-build
User tests: Successful: Unsuccessful:
Summary of Changes
The Dart-Sass engine has a "new" API, where instead of renderSync and a configuration object, it just uses compile() with the filename instead. As far as I can see, this PR fixes that deprecation warning. Since this only affects our build process, I would consider this to be safe for adoption in 5.2.
Testing Instructions
Codereview.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository |
| Labels |
Added:
PR-5.2-dev
|
||
LadySolveig
- comment
- 19 Jan 2025
I have tested this item ✅ successfully on 37b0dfa
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44659.
| Status | Pending | ⇒ | Ready to Commit |
richard67
- comment
- 19 Jan 2025
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44659.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-01-19 10:03:33 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
RTC
|
||
I have tested this item ✅ successfully on 37b0dfa
I think code review is not really sufficient for testing this PR, so I have done (in addition to the review) following tests:
Run a
php ./build/build.php --remote=HEAD --exclude-gzip --exclude-zstdon a clean branch one time without and one time with this PR applied and compare the content of the created packagesbuild/tmp/packages/Joomla_5.2.4-dev-Development-Full_Package.zip.Hint: You can fetch this PR into a local branch "test-pr-44659" for the test with
git fetch upstream pull/44659/head:test-pr-44659and then checkout that branch with
git co test-pr-44659Result: There are no differences except of the usual different autoloader IDs and partly different ordering of assets in
joomla.asset.jsonfiles.Run
npm cione time without and one time with this PR applied under the same starting conditions (clean branch withcomposer installhaving run) and compare the output.Hint: For easy comparison of the output you can run npm and redirect all standard and error output into a test file on Linux or Windows with WSL like this:
npm ci > ./build/npm-ci-with-pr.txt 2>&1Result: The deprecation messages
Deprecation [legacy-js-api]: The legacy JS API is deprecated and will be removed in Dart Sass 2.0.0.have disappeared with this PR applied.This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44659.