[#44607] - [5.3] Logical css joomla tabs
- Fixed in Code Base
- 8 Feb 2025
- Medium
- Build: 5.3-dev
- # 44607
- Diff
- brianteeman:logical_css
User tests: Successful: Unsuccessful:
Use logical CSS properties to avoid having to set different LTR and RTL css
This is a redo of #36034 which could not be merged at the time as browsers didnt support logical css properties for floats. They do now https://caniuse.com/?search=float-inline
The css changed is for the highlighted areas of the screenshot on mobile views. There is no visual change in LTR. In RTL There is no visual change in highlighted areas BUT a bug is fixed which forced the table to be 1400+ pixels wide with the headers to be displayed instead of positioned off screen
Summary of Changes
Testing Instructions
As this is a scss change then you will need to either rebuild the css or test with a prebuilt package
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
PR-5.3-dev
|
||
| Title |
|
||||||
… but how to test the fixed bug?
When you are on the permissions view see if you can scroll left/right.
Before the PR and using RTL then you could scroll massively to the left.
Hint (instead of installing an RTL language you can often test just by changing the value here
https://github.com/joomla/joomla-cms/blob/5.2-dev/administrator/language/en-GB/langmetadata.xml#L16
Using the Pull Request and RTL then i could scroll massively to the right.
Thanks for the Hint.
I have tested this item ✅ successfully on e3d574f
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44607.
I have tested this item ✅ successfully on e3d574f
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44607.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44607.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-02-08 14:33:58 |
| Closed_By | ⇒ | richard67 |
Thanks.
@brianteeman Visual no difference …
… but how to test the fixed bug?