Language Change PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
10 Dec 2024

Pull Request for Issue #42824 .

Summary of Changes

Add a field param to the text field plugin to allow content.prepare plugins such as mailcloak to process the field

Testing Instructions

Create a text field for an article
Enter an email address into the article
Check the output of the article and see if the email address is cloaked

Actual result BEFORE applying this Pull Request

Email address is plain text

Expected result AFTER applying this Pull Request

Email address is plain text
Change the field value in the text field plugin to Yes - the email address is cloaked
Change the field value in the field to No - the email address is not cloaked
Change the field value in the field to Yes - the email address is cloaked

image

image

This is fully b/c as the content.prepare is not enabled by default

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar brianteeman brianteeman - open - 10 Dec 2024
avatar brianteeman brianteeman - change - 10 Dec 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Dec 2024
Category Administration Language & Strings Front End Plugins
avatar brianteeman brianteeman - change - 10 Dec 2024
The description was changed
avatar brianteeman brianteeman - edited - 10 Dec 2024
avatar brianteeman brianteeman - change - 10 Dec 2024
Labels Added: Language Change PR-5.3-dev
avatar fgsw fgsw - test_item - 10 Dec 2024 - Tested successfully
avatar fgsw
fgsw - comment - 10 Dec 2024

I have tested this item ✅ successfully on 411a9be

Comment:

#### Test instructions:
Change the field value in the field to Yes - the email address is not cloaked
#### Test result:
Change the field value in the field to Yes - the email address is cloaked.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44597.
avatar brianteeman brianteeman - change - 10 Dec 2024
The description was changed
avatar brianteeman brianteeman - edited - 10 Dec 2024
avatar brianteeman
brianteeman - comment - 10 Dec 2024

@fgsw thanks I fixed the error in the test instructions

avatar chmst chmst - alter_testresult - 14 Dec 2024 - quy: Tested successfully
avatar alikon
alikon - comment - 16 Dec 2024

setting RTC cause it was successfully tested by @Quy too

avatar alikon alikon - change - 16 Dec 2024
Status Pending Ready to Commit
avatar alikon
alikon - comment - 16 Dec 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44597.

avatar rdeutz
rdeutz - comment - 7 Jan 2025

Because we have tow PRs solving the same problem (#44233), we will discuss this in our next meeting what is the better way.

avatar rdeutz
rdeutz - comment - 10 Jan 2025

Quick feedback on this issue, we discussed it but could find an agreement. Some don't want this at all, some want to use another event .... still in discussion.

Add a Comment

Login with GitHub to post a comment