Feature RTC PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
9 Dec 2024

Pull Request for Issue #44589 .

Summary of Changes

add log entry when edit a contact from frontend

Testing Instructions

  • Make sure the Contacts component is enabled in the User Action Logs global configuration
  • Display a Contact via the frontend (eg. via menu item)
  • Edit the contact and save

Actual result BEFORE applying this Pull Request

No action is recorded.

Expected result AFTER applying this Pull Request

An action for the contact updated is added to the Action Log

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar alikon alikon - open - 9 Dec 2024
avatar alikon alikon - change - 9 Dec 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Dec 2024
Category SQL Administration com_admin Postgresql Front End com_contact Installation Plugins
ff8a7f1 9 Dec 2024 avatar alikon cs
avatar alikon alikon - change - 9 Dec 2024
Labels Added: PR-5.3-dev
avatar alikon alikon - change - 9 Dec 2024
The description was changed
avatar alikon alikon - edited - 9 Dec 2024
avatar alikon alikon - change - 9 Dec 2024
Title
log_edit_contact_frontend
[5]log edit contact from frontend
avatar alikon alikon - edited - 9 Dec 2024
avatar AndySDH
AndySDH - comment - 9 Dec 2024

Tested partially successfully. With the current state of the PR, I get a double entry in the User Action Log every time you save a contact.

I think the change you made to ContactController.php is not needed.

If I remove the change made to ContactController.php, then it works fine with just one entry in the Action Log when saving a contact.

avatar joomla-cms-bot joomla-cms-bot - change - 9 Dec 2024
Category SQL Administration com_admin Postgresql Front End com_contact Installation Plugins SQL Administration com_admin Postgresql Front End com_contact Installation
avatar joomla-cms-bot joomla-cms-bot - change - 9 Dec 2024
Category SQL Administration com_admin Postgresql Front End com_contact Installation SQL Administration com_admin Postgresql Installation
avatar alikon
alikon - comment - 9 Dec 2024

@AndySDH you are right should be Ok now

avatar AndySDH AndySDH - test_item - 9 Dec 2024 - Tested successfully
avatar AndySDH
AndySDH - comment - 9 Dec 2024

I have tested this item ✅ successfully on af3f257

Thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44596.

avatar fgsw fgsw - test_item - 11 Dec 2024 - Tested successfully
avatar fgsw
fgsw - comment - 11 Dec 2024

I have tested this item ✅ successfully on af3f257

Test by using prebuilt package.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44596.

avatar alikon alikon - change - 11 Dec 2024
Status Pending Ready to Commit
avatar alikon
alikon - comment - 11 Dec 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44596.

avatar rdeutz rdeutz - change - 7 Jan 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-01-07 09:01:38
Closed_By rdeutz
Labels Added: Feature RTC
avatar rdeutz rdeutz - close - 7 Jan 2025
avatar rdeutz rdeutz - merge - 7 Jan 2025
avatar rdeutz
rdeutz - comment - 7 Jan 2025

Thanks

Add a Comment

Login with GitHub to post a comment