RTC PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
6 Dec 2024

Summary of Changes

Adds override compare functionality to plugin overrides

Testing Instructions

In the template manager create an override for any plugin
Select one of the files in the override

Actual result BEFORE applying this Pull Request

Show Original File and Show Differences not present

image

Expected result AFTER applying this Pull Request

Show Original File and Show Differences are present and you can se the differences etc

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar brianteeman brianteeman - open - 6 Dec 2024
avatar brianteeman brianteeman - change - 6 Dec 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Dec 2024
Category Administration com_templates
ab53b22 6 Dec 2024 avatar brianteeman cs
avatar brianteeman brianteeman - change - 6 Dec 2024
Labels Added: PR-5.3-dev
avatar fgsw fgsw - test_item - 7 Dec 2024 - Tested successfully
avatar fgsw
fgsw - comment - 7 Dec 2024

I have tested this item ✅ successfully on ab53b22


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44588.

e0fe223 7 Dec 2024 avatar brianteeman cs
avatar richard67 richard67 - alter_testresult - 7 Dec 2024 - fgsw: Tested successfully
avatar richard67 richard67 - alter_testresult - 7 Dec 2024 - Quy: Tested successfully
avatar richard67 richard67 - change - 7 Dec 2024
The description was changed
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 7 Dec 2024

I've restored @fgsw 's test result in the issue tracker and have set the test result for @Quy as he can't do that currently so asked in Mattermost to do that.

=> RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44588.

avatar richard67 richard67 - edited - 7 Dec 2024
avatar HLeithner HLeithner - change - 8 Dec 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-12-08 09:49:22
Closed_By HLeithner
Labels Added: RTC
avatar HLeithner HLeithner - close - 8 Dec 2024
avatar HLeithner HLeithner - merge - 8 Dec 2024
avatar HLeithner
HLeithner - comment - 8 Dec 2024

slightly related is the wrong type usage for array access $explodeArray['1'] casts in implizit type conversation to integer which is not correct here. So if someone likes to fix this please go ahead.

Add a Comment

Login with GitHub to post a comment