[#44587] - [5.3] Move code to log model in new scheduler history view
- Fixed in Code Base
- 7 Jan 2025
- Medium
- Build: 5.3-dev
- # 44587
- Diff
- Digital-Peak:scheduler/cleanup
User tests: Successful: Unsuccessful:
Summary of Changes
This is a followup for #42530 which uses the existing functions of the MVC API and removes some duplicated code. Like that are all ACL checks done, the default events triggered and code looks more inline with the rest of the core.
Testing Instructions
- Run a task
- Open the new task history view
- Delete a log entry
- Clear the whole history
Actual result BEFORE applying this Pull Request
All works.
Expected result AFTER applying this Pull Request
All works.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Front End Plugins |
| Title |
|
||||||
Please check the response of the ajax request in the browser console. What for an error did you get?
Call to undefined method Joomla\CMS\Document\JsonDocument::getToolbar()
Se your server into debug mode and post the whole stack trace please.
Set your server into debug mode and post the whole stack trace please.
my fault there was an obsolete plugin listening onBeforeRender
I have tested this item ✅ successfully on 7bbfc2a
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44587.
| Labels |
Added:
Language Change
PR-5.3-dev
|
||
I have tested this item ✅ successfully on f9bfbdf
I have successfully tested this as instructed. Worked beautifully.
Thanks laoneo.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44587.
As I added only types, removed an obsolete string and alpha ordered the new strings, I mark this as RTC because it needs to go into an alpha.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44587.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44587.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-01-07 18:08:14 |
| Closed_By | ⇒ | rdeutz |
Thanks.
just applied the pr and runned a default task