@wilsonge the next PR from you with ZERO description or test instructions will be closed. Even the title is not descriptive

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4456.

This is codestyle. Like how do you add a desription for that???

Well for a start you could have said it was a code style change

From the title alone "fix rules" it could mean anything and from looking at
the code it is more than code style. (tabulation, spaces, comments etc)

You must explain why the changes (extra code) are being made and what it
effects so that people can test it. Otherwise the people on the JBS will
just ignore it as they wont have a clue what to do with it and it will be
ignored and then closed for inactivity - wasting everyones time. Or even
worse people will just accept it without it being tested thoroughly because
they dont know what to test and as a result we break joomla.

On 5 October 2014 10:08, George Wilson notifications@github.com wrote:

This is codestyle. Like how do you add a desription for that???

—
Reply to this email directly or view it on GitHub
#4456 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Tabs, spaces and code comments are exactly what code style is about. Code style guides for this for example state that you must have a space between the foreach and the ( so I did that plus the comments required according to the code style guide located at http://mbabker.github.io/jcms-codestyle/reports/components.xml

I misread the diff to show additional lines of code - but PLEASE at a
minimum state in the description that this is code style.

If nothing else it breaks the issue tracker when you dont have a
description as it is a required field

On 5 October 2014 10:22, George Wilson notifications@github.com wrote:

Tabs, spaces and code comments are exactly what code style is about. Code
style guides for this for example state that you must have a space between
the foreach and the ( so I did that plus the comments required according
to the code style guide located at
http://mbabker.github.io/jcms-codestyle/reports/components.xml

—
Reply to this email directly or view it on GitHub
#4456 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

PR OK. Merging.